Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around intermittent crash when saving snapshot from Data Browser #2710

Merged

Conversation

aawdls
Copy link
Contributor

@aawdls aawdls commented Oct 14, 2021

Our users report that intermittently CSS will crash when saving a snapshot from the data browser.

The output is

[xcb] Most likely this is a multi-threaded client and XInitThreads has not been called
[xcb] Aborting, sorry about that.
java: xcb_io.c:165: dequeue_pending_request: Assertion `!xcb_xlib_unknown_req_in_deq' failed.

We deduced this is another manifrstation of the issue described here #2660 and here ControlSystemStudio/phoebus#705

This PR implements a similar workaround for the Save Snapshot. i.e. to create the image on the UI thread.

The SWT issue is still open on eclipse.org. One commenter reports that a later Eclipse version no longer has this behaviour, so it is possible that it will not be fixed in 2020-12. I expect that for us to upgrade the Eclipse version is a very big task and therefore prefer to implement this workaround in order to fix this crash for an upcoming DLS release.

cc @rjwills28

@aawdls aawdls requested review from kasemir and shroffk October 14, 2021 11:10
@kasemir
Copy link
Contributor

kasemir commented Oct 14, 2021

@willrogers thanks for creating the SWT/eclipse https://bugs.eclipse.org/bugs/show_bug.cgi?id=568859, very happy to see some confirmation there (should work, but creating an image is unfortunately only possible on UI thread).

@aawdls aawdls merged commit c3370cb into ControlSystemStudio:master Oct 14, 2021
@aawdls aawdls deleted the ofl568_snapshot_crash branch October 14, 2021 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants