Work around intermittent crash when saving snapshot from Data Browser #2710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our users report that intermittently CSS will crash when saving a snapshot from the data browser.
The output is
We deduced this is another manifrstation of the issue described here #2660 and here ControlSystemStudio/phoebus#705
This PR implements a similar workaround for the Save Snapshot. i.e. to create the image on the UI thread.
The SWT issue is still open on eclipse.org. One commenter reports that a later Eclipse version no longer has this behaviour, so it is possible that it will not be fixed in 2020-12. I expect that for us to upgrade the Eclipse version is a very big task and therefore prefer to implement this workaround in order to fix this crash for an upcoming DLS release.
cc @rjwills28