Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around intermittent crash when saving snapshot from Data Browser #2710

Merged
merged 2 commits into from
Oct 14, 2021
+8 −3
Merged

Work around intermittent crash when saving snapshot from Data Browser #2710

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ab7e661
Fixing bug causing CSS to occasionally crash when trying to save a sn…
rjwills28 Oct 13, 2021
17a0af3
Adding comment to why we need to run on the UI thread.
rjwills28 Oct 13, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions ...-plugins/org.csstudio.swt.rtplot/src/org/csstudio/swt/rtplot/internal/SnapshotAction.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -76,10 +76,15 @@ protected IStatus run(final IProgressMonitor progress)
try
{ // Create snapshot, save to file
final ImageLoader loader = new ImageLoader();
final Image image = plot.getImage();
loader.data = new ImageData[] { image.getImageData() };
image.dispose();
// In Eclipse 2020-12 we cannot seem to get the Image on
// a background thread so must schedule it on the UI thread.
shell.getDisplay().syncExec(() -> {
final Image image = plot.getImage();
loader.data = new ImageData[] { image.getImageData() };
image.dispose();
});
loader.save(path.get(), SWT.IMAGE_PNG);

// Done!
break;
}
Expand Down