fix: filter changes no longer blank the event list - #114
Merged
Abd-Standard merged 1 commit intoJun 20, 2026
Merged
Conversation
When a filter was applied while the user was scrolled deep, the windowing useMemo computed startIndex from a stale scrollTop that exceeded the new list's bounds, causing events.slice() to return nothing and the list to go blank. Fix: clamp scrollTop to maxScrollTop before computing startIndex so the visible window is always within the filtered result's bounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #87
Root cause
The virtual list computes its visible window using
scrollTop(a React state value). When a filter is applied and the event list shrinks, the scroll reset happens in auseEffect— which runs after the render. On that first render with the new shorter list, the stalescrollTopproduces astartIndexbeyond the end of the filtered array, soevents.slice(startIndex, endIndex)returns[]and the list goes blank.Fix
Clamp
scrollTopto the maximum valid scroll offset before computingstartIndexinside theuseMemo. This is a pure calculation change — one extra line — and makes the windowing logic correct regardless of effect timing.Tests added
All 3 tests pass.