Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new tools): Data Storage/Transfer Units Converter #1289

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

sharevb
Copy link
Contributor

@sharevb sharevb commented Sep 11, 2024

New Tool: Data Transfer Rate Converter
New Tool: Data Storage Units Converter (with MB, MiB and Mb)

Fix #539 #785 #1160 #848

Data Storage Units Converter inspired by #948 by @utf26

Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
it-tools ✅ Ready (Inspect) Visit Preview Sep 21, 2024 8:10am

…Converter

New Tool: Data Transfer Rate Converter
New Tool: Data Storage Units Converter (with MB, MiB and Mb)

Fix CorentinTh#539 CorentinTh#785 CorentinTh#1160 CorentinTh#848

Data Storage Units Converter inspired by CorentinTh#948 by @utf26
@steffenrapp
Copy link
Contributor

@sharevb Thanks for your work! I'm wondering why the tool says 1MB = 1000KB. Shouldn't it be 1024KB? The tool from #948 calculates that correctly.

image

@steffenrapp
Copy link
Contributor

Also the separators look wrong to me. Should be a dot for decimals instead of a comma in English and vice versa?

@sharevb
Copy link
Contributor Author

sharevb commented Sep 11, 2024

Hi @steffenrapp, I would have also said MB is 1024² but in fact MB is decimal 1000² and MiB is binary 1024² : https://en.wikipedia.org/wiki/Megabyte ; confusing, I admit

@sharevb
Copy link
Contributor Author

sharevb commented Sep 11, 2024

Hi @steffenrapp, regarding comma or dot, the display use your browser language but right, it should be always English

@steffenrapp
Copy link
Contributor

Sorry my bad 🤦🏻‍♂️

@sharevb
Copy link
Contributor Author

sharevb commented Sep 11, 2024

Hi @steffenrapp, implemented "always dot" (and no thousand separator) as your bug report. Thanks, it is clearer now.

@steffenrapp
Copy link
Contributor

Hi @sharevb what do you think if the decimal separator would be depending on the selected language? Might be a general global implementation to define and later use those rules.

@sharevb
Copy link
Contributor Author

sharevb commented Sep 12, 2024

Hi @steffenrapp, I am not sure it is not confusing to present as local formating (at least for this tool, since it is IT tools, it is supposed to be IT formating) and also because I presume you have a German language on your computer and you were surprise that it was "1.000,00"

@steffenrapp
Copy link
Contributor

steffenrapp commented Sep 12, 2024

Hi @sharevb I understand your perspective and think it makes sense like that. A general decision for the product should be made by @CorentinTh if he wants some clear guidelines.

EDIT: Yes my devices are German 😀 In fact I was confused because I had English select in the tool and it was the German formatting.

@luiscachog
Copy link

Waiting for this new tool! Thanks!!

@quyvsquy
Copy link

Hi @sharevb , can you add fullname like this, for more details
image

Copy link

sonarcloud bot commented Sep 21, 2024

@sharevb
Copy link
Contributor Author

sharevb commented Sep 21, 2024

Hi @quyvsquy (and @steffenrapp and @CorentinTh) added label for units (right, it is better, thanks)

@steffenrapp
Copy link
Contributor

Hi @sharevb Nice looks good 👍🏼

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[NEW TOOL] Data Storage/Transfers Converter
4 participants