Change custom error page location & remove htpasswd placeholder #1530
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dchiller
force-pushed
the
refactor-error-pgs-and-psswd
branch
from
30aba04
to
2c4fb30
Compare
lucasmarchd01
approved these changes
Jun 17, 2024
27 tasks
This was referenced Aug 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes features that were added in #1520.
#1520 added a placeholder password file (
nginx/password/.htpasswd) that was then overwritten on the staging server by ansible. This meant that subsequent deployments with ansible on the staging server would fail because a subsequentgit pullwould find changes to the local working directory. This PR removes that placeholder.htpasswdfile.This PR also refactors the custom error pages served by nginx to make the nginx configuration file simpler.
Finally, the custom error page was not showing when gunicorn returned a 500 error. Turning the
proxy_intercept_errorsconfiguration "on" means that nginx now intercepts this error from gunicorn and serves the custom 500 error page.Fixes #1519. Refs https://github.com/dact-chant/ansible.cantus-db/issues/41.