Make "Country" and "Source" columns sortable on Source List page #1592
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The sortable_header inclusion tag renders a table header for a column for which a view provides sort functionality. The tag adds links to the header that include `sort` and `order` query parameters that can be used by the view to sort queryset results.
- add functionality to sort by a source's holding institution country (the "Country" column) and city/name/siglum (the "Source" column) in the Source List view - use the sortable_header helper tag for sortable column headers in the source_list.html template - fix the value used in the source column to the source's heading property
- remove unused variables - reduce number of statements with assignment operator
lucasmarchd01
approved these changes
Aug 13, 2024
21 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1217 by making the source list page sortable by the "country" and "source" (city + institution + siglum) columns.
Additionally, this PR adds the
sortable_headertemplate tag. This tag renders a column header for a sortable column, reducing the need to repeat this construction multiple times in thesource_listand other templates. This template tag can be reused in any template where we sort by column headers (I'm thinking here especially of the Chant Search table; I've made #1593 for this).Finally, makes some minor code cleanliness changes to the SourceList view: annotates function return type and makes use of the assignment operator to reduce the number of statements in the
get_querysetview.