Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make "Country" and "Source" columns sortable on Source List page #1592

Merged
merged 3 commits into from
Aug 13, 2024
Merged

Make "Country" and "Source" columns sortable on Source List page #1592

merged 3 commits into from
Aug 13, 2024
+105 −27

Commits on Aug 9, 2024

  1. feat(templates): add sortable_header template tag 

    The sortable_header inclusion tag renders a table header
for a column for which a view provides sort functionality.
The tag adds links to the header that include `sort` and `order`
query parameters that can be used by the view to sort queryset
results.
    @dchiller
    dchiller committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    09c5749 View commit details
    Browse the repository at this point in the history

  2. feat(source list): add sorting by country and source columns 

    - add functionality to sort by a source's holding institution
country (the "Country" column) and city/name/siglum (the "Source"
column) in the Source List view
- use the sortable_header helper tag for sortable column headers
in the source_list.html template
- fix the value used in the source column to the source's heading
property
    @dchiller
    dchiller committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    c36febf View commit details
    Browse the repository at this point in the history

  3. refactor(source list view): minor source list view refactoring 

    - remove unused variables
- reduce number of statements with assignment operator
    @dchiller
    dchiller committed Aug 9, 2024
    Configuration menu
    Copy the full SHA
    a206538 View commit details
    Browse the repository at this point in the history