[DC-1790] Look into User Issue "not authorized" ingest failure despite correct permissions #2037
+505
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjohanek
requested review from
calypsomatic and
samanehsan
and removed request for
a team
calypsomatic
approved these changes
Oct 21, 2025
samanehsan
reviewed
Oct 21, 2025
| permissions = | ||
| storageAsPet.testIamPermissions( | ||
| bucket, List.of(GCS_SOURCE_BUCKET_REQUIRED_PERMISSION), options); | ||
| logger.info("Permissions test result: {}", permissions); |
There was a problem hiding this comment.
I don't think we need to log the result of every bucket permissions check, since the important/useful bit is whether it fails. What do you think?
samanehsan
approved these changes
Oct 21, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira ticket: https://broadworkbench.atlassian.net/browse/DC-1790
Addresses
User getting not authorized error despite being authorized. The issue was we were burying an error message that gave helpful information. The billing account on the dataset is disabled. Instead of catching that error and never showing it to the user, we will add more information to it and show the original error message.
Summary of changes
Show original error message and add additional information to it to help the user.
The original code buried an error message, this surfaces it.
Testing Strategy
This method was originally untested, so this adds unit tests for the method.