Update dotnet-install scripts for impending change of .NET install domains #6484

andrewlock · 2024-12-24T13:22:21Z

Summary of changes

Updates the dotnet-install.sh and dotnet-install.ps scripts following advice in dotnet/announcements#336

Reason for change

From the linked announcement:

Some .NET binaries and installers are hosted on Azure Content Delivery Network (CDN) domains that end in .azureedge.net. These domains are hosted by edg.io, which will soon cease operations due to bankruptcy. We are required to migrate to a new CDN and will be using new domains going forward. It is possible that .azureedge.net domains will have downtime or become permanently unavailable.

Implementation details

Update the scripts with the versions provided in the initial announcements. These scripts aren't "final", and we don't need to merge them yet (and we will need to update the VMs when we do), so for now this is a "break glass if things stop working" scenario. Not that the powershell script isn't signed, so we should definitely wait for that too if we can.

Test coverage

This PR is the test - as long as it builds ok, we're good

Other details

I haven't really looked through the changes. They're mostly superficial, other than preferring the new CDN domain and using a fallback

datadog-ddstaging · 2024-12-24T13:54:19Z

Datadog Report

Branch report: andrew/ci/prepare-fix-for-changing-dotnet-install-script
Commit report: 5b98953
Test service: dd-trace-dotnet

✅ 0 Failed, 453674 Passed, 2812 Skipped, 19h 39m 8.83s Total Time

andrewlock · 2024-12-24T13:56:04Z

Execution-Time Benchmarks Report ⏱️

Execution-time results for samples comparing the following branches/commits:

Execution-time benchmarks measure the whole time it takes to execute a program. And are intended to measure the one-off costs. Cases where the execution time results for the PR are worse than latest master results are shown in red. The following thresholds were used for comparing the execution times:

Welch test with statistical test for significance of 5%
Only results indicating a difference greater than 5% and 5 ms are considered.

Note that these results are based on a single point-in-time result for each branch. For full results, see the dashboard.

Graphs show the p99 interval based on the mean and StdDev of the test run, as well as the mean value of the run (shown as a diamond below the graph).

gantt
    title Execution time (ms) FakeDbCommand (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6484) - mean (68ms)  : 65, 71
     .   : milestone, 68,
    master - mean (69ms)  : 65, 72
     .   : milestone, 69,

    section CallTarget+Inlining+NGEN
    This PR (6484) - mean (980ms)  : 957, 1004
     .   : milestone, 980,
    master - mean (977ms)  : 955, 1000
     .   : milestone, 977,

gantt
    title Execution time (ms) FakeDbCommand (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6484) - mean (107ms)  : 105, 110
     .   : milestone, 107,
    master - mean (107ms)  : 105, 109
     .   : milestone, 107,

    section CallTarget+Inlining+NGEN
    This PR (6484) - mean (677ms)  : 660, 695
     .   : milestone, 677,
    master - mean (679ms)  : 662, 695
     .   : milestone, 679,

gantt
    title Execution time (ms) FakeDbCommand (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6484) - mean (91ms)  : 89, 94
     .   : milestone, 91,
    master - mean (91ms)  : 89, 93
     .   : milestone, 91,

    section CallTarget+Inlining+NGEN
    This PR (6484) - mean (635ms)  : 620, 650
     .   : milestone, 635,
    master - mean (634ms)  : 614, 654
     .   : milestone, 634,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Framework 4.6.2) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6484) - mean (193ms)  : 189, 198
     .   : milestone, 193,
    master - mean (193ms)  : 189, 197
     .   : milestone, 193,

    section CallTarget+Inlining+NGEN
    This PR (6484) - mean (1,104ms)  : 1076, 1132
     .   : milestone, 1104,
    master - mean (1,099ms)  : 1070, 1129
     .   : milestone, 1099,

gantt
    title Execution time (ms) HttpMessageHandler (.NET Core 3.1) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6484) - mean (277ms)  : 272, 282
     .   : milestone, 277,
    master - mean (278ms)  : 272, 283
     .   : milestone, 278,

    section CallTarget+Inlining+NGEN
    This PR (6484) - mean (870ms)  : 839, 901
     .   : milestone, 870,
    master - mean (871ms)  : 844, 897
     .   : milestone, 871,

gantt
    title Execution time (ms) HttpMessageHandler (.NET 6) 
    dateFormat  X
    axisFormat %s
    todayMarker off
    section Baseline
    This PR (6484) - mean (267ms)  : 261, 273
     .   : milestone, 267,
    master - mean (266ms)  : 262, 270
     .   : milestone, 266,

    section CallTarget+Inlining+NGEN
    This PR (6484) - mean (850ms)  : 815, 884
     .   : milestone, 850,
    master - mean (855ms)  : 825, 885
     .   : milestone, 855,

andrewlock · 2024-12-24T15:00:52Z

Benchmarks Report for tracer 🐌

Benchmarks for #6484 compared to master:

1 benchmarks are slower, with geometric mean 1.168
All benchmarks have the same allocations

The following thresholds were used for comparing the benchmark speeds:

Mann–Whitney U test with statistical test for significance of 5%
Only results indicating a difference greater than 10% and 0.3 ns are considered.

Allocation changes below 0.5% are ignored.

Benchmark details

Benchmarks.Trace.ActivityBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`StartStopWithChild`	net6.0	8.15μs	45.4ns	305ns	0.0191	0.00765	0	5.61 KB
master	`StartStopWithChild`	netcoreapp3.1	10.3μs	56.7ns	345ns	0.026	0.0104	0	5.8 KB
master	`StartStopWithChild`	net472	16.4μs	58.8ns	228ns	1.04	0.311	0.0901	6.21 KB
#6484	`StartStopWithChild`	net6.0	8.12μs	46.6ns	376ns	0.0164	0.00818	0	5.61 KB
#6484	`StartStopWithChild`	netcoreapp3.1	10.1μs	57.1ns	370ns	0.0149	0.00496	0	5.8 KB
#6484	`StartStopWithChild`	net472	16.4μs	48.6ns	188ns	1.04	0.3	0.0999	6.21 KB

Benchmarks.Trace.AgentWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	485μs	354ns	1.37μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	648μs	504ns	1.89μs	0	2.7 KB
master	`WriteAndFlushEnrichedTraces`	net472	853μs	631ns	2.28μs	0.425	3.3 KB
#6484	`WriteAndFlushEnrichedTraces`	net6.0	486μs	301ns	1.13μs	0	2.7 KB
#6484	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	657μs	416ns	1.61μs	0	2.7 KB
#6484	`WriteAndFlushEnrichedTraces`	net472	846μs	630ns	2.27μs	0.422	3.3 KB

Benchmarks.Trace.AspNetCoreBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendRequest`	net6.0	153μs	1.2μs	11.9μs	0.14	14.47 KB
master	`SendRequest`	netcoreapp3.1	178μs	1.2μs	11.9μs	0.166	17.27 KB
master	`SendRequest`	net472	0ns	0ns	0ns	0	0 b
#6484	`SendRequest`	net6.0	157μs	1.1μs	10.8μs	0.144	14.47 KB
#6484	`SendRequest`	netcoreapp3.1	188μs	1.55μs	15.5μs	0.229	17.27 KB
#6484	`SendRequest`	net472	0.000663ns	0.000307ns	0.00119ns	0	0 b

Benchmarks.Trace.CIVisibilityProtocolWriterBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Gen 2	Allocated
master	`WriteAndFlushEnrichedTraces`	net6.0	557μs	2.53μs	9.78μs	0.551	0	0	41.52 KB
master	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	700μs	3.9μs	25.6μs	0.329	0	0	41.86 KB
master	`WriteAndFlushEnrichedTraces`	net472	819μs	2μs	7.5μs	8.17	2.45	0.408	53.32 KB
#6484	`WriteAndFlushEnrichedTraces`	net6.0	563μs	2.91μs	13.6μs	0.551	0	0	41.47 KB
#6484	`WriteAndFlushEnrichedTraces`	netcoreapp3.1	703μs	3.85μs	22.8μs	0.351	0	0	41.92 KB
#6484	`WriteAndFlushEnrichedTraces`	net472	834μs	3.3μs	12.8μs	8.17	2.45	0.408	53.3 KB

Benchmarks.Trace.DbCommandBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`ExecuteNonQuery`	net6.0	1.28μs	1.4ns	5.43ns	0.0142	0	1.02 KB
master	`ExecuteNonQuery`	netcoreapp3.1	1.81μs	1.73ns	6.71ns	0.0135	0	1.02 KB
master	`ExecuteNonQuery`	net472	2.1μs	3.89ns	14.6ns	0.157	0.00104	987 B
#6484	`ExecuteNonQuery`	net6.0	1.25μs	0.783ns	2.93ns	0.0144	0	1.02 KB
#6484	`ExecuteNonQuery`	netcoreapp3.1	1.83μs	2.11ns	7.9ns	0.0136	0	1.02 KB
#6484	`ExecuteNonQuery`	net472	2.07μs	2.12ns	7.92ns	0.157	0.00104	987 B

Benchmarks.Trace.ElasticsearchBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`CallElasticsearch`	net6.0	1.23μs	1.08ns	4.03ns	0.0137	976 B
master	`CallElasticsearch`	netcoreapp3.1	1.58μs	0.773ns	2.99ns	0.0127	976 B
master	`CallElasticsearch`	net472	2.58μs	0.927ns	3.47ns	0.157	995 B
master	`CallElasticsearchAsync`	net6.0	1.34μs	0.45ns	1.68ns	0.0134	952 B
master	`CallElasticsearchAsync`	netcoreapp3.1	1.69μs	0.547ns	2.05ns	0.0137	1.02 KB
master	`CallElasticsearchAsync`	net472	2.66μs	1.14ns	4.27ns	0.167	1.05 KB
#6484	`CallElasticsearch`	net6.0	1.22μs	0.406ns	1.52ns	0.0134	976 B
#6484	`CallElasticsearch`	netcoreapp3.1	1.6μs	0.683ns	2.65ns	0.0127	976 B
#6484	`CallElasticsearch`	net472	2.52μs	2.56ns	9.9ns	0.157	995 B
#6484	`CallElasticsearchAsync`	net6.0	1.27μs	0.833ns	3.12ns	0.0134	952 B
#6484	`CallElasticsearchAsync`	netcoreapp3.1	1.61μs	0.978ns	3.39ns	0.0137	1.02 KB
#6484	`CallElasticsearchAsync`	net472	2.69μs	2.49ns	9.33ns	0.167	1.05 KB

Benchmarks.Trace.GraphQLBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`ExecuteAsync`	net6.0	1.34μs	0.771ns	2.89ns	0.0134	952 B
master	`ExecuteAsync`	netcoreapp3.1	1.63μs	1.16ns	4.34ns	0.0122	952 B
master	`ExecuteAsync`	net472	1.77μs	0.599ns	2.32ns	0.145	915 B
#6484	`ExecuteAsync`	net6.0	1.35μs	1.38ns	5.35ns	0.0135	952 B
#6484	`ExecuteAsync`	netcoreapp3.1	1.61μs	0.942ns	3.53ns	0.0123	952 B
#6484	`ExecuteAsync`	net472	1.84μs	1.22ns	4.58ns	0.145	915 B

Benchmarks.Trace.HttpClientBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendAsync`	net6.0	4.34μs	2.62ns	9.8ns	0.0324	2.31 KB
master	`SendAsync`	netcoreapp3.1	5.35μs	2.18ns	8.15ns	0.0373	2.85 KB
master	`SendAsync`	net472	7.36μs	2.92ns	11.3ns	0.493	3.12 KB
#6484	`SendAsync`	net6.0	4.5μs	9.05ns	32.6ns	0.0314	2.31 KB
#6484	`SendAsync`	netcoreapp3.1	5.45μs	2.43ns	9.09ns	0.0385	2.85 KB
#6484	`SendAsync`	net472	7.34μs	1.44ns	5.59ns	0.494	3.12 KB

Benchmarks.Trace.ILoggerBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	1.53μs	0.58ns	2.17ns	0.023	1.64 KB
master	`EnrichedLog`	netcoreapp3.1	2.22μs	3.9ns	14.6ns	0.0222	1.64 KB
master	`EnrichedLog`	net472	2.72μs	1.05ns	3.93ns	0.25	1.57 KB
#6484	`EnrichedLog`	net6.0	1.49μs	0.825ns	3.2ns	0.0227	1.64 KB
#6484	`EnrichedLog`	netcoreapp3.1	2.2μs	1.02ns	3.96ns	0.022	1.64 KB
#6484	`EnrichedLog`	net472	2.65μs	1.33ns	4.97ns	0.249	1.57 KB

Benchmarks.Trace.Log4netBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Gen 1	Allocated
master	`EnrichedLog`	net6.0	115μs	170ns	657ns	0.0576	0	4.28 KB
master	`EnrichedLog`	netcoreapp3.1	121μs	199ns	746ns	0	0	4.28 KB
master	`EnrichedLog`	net472	150μs	150ns	560ns	0.673	0.224	4.46 KB
#6484	`EnrichedLog`	net6.0	118μs	157ns	610ns	0	0	4.28 KB
#6484	`EnrichedLog`	netcoreapp3.1	124μs	167ns	626ns	0.0617	0	4.28 KB
#6484	`EnrichedLog`	net472	153μs	151ns	587ns	0.691	0.23	4.46 KB

Benchmarks.Trace.NLogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	3.04μs	0.838ns	3.25ns	0.0303	2.2 KB
master	`EnrichedLog`	netcoreapp3.1	4.2μs	3.31ns	12.8ns	0.0294	2.2 KB
master	`EnrichedLog`	net472	4.84μs	1.46ns	5.65ns	0.319	2.02 KB
#6484	`EnrichedLog`	net6.0	2.89μs	1.13ns	4.38ns	0.0302	2.2 KB
#6484	`EnrichedLog`	netcoreapp3.1	4.21μs	1.25ns	4.68ns	0.0297	2.2 KB
#6484	`EnrichedLog`	net472	4.93μs	1.04ns	4.02ns	0.32	2.02 KB

Benchmarks.Trace.RedisBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`SendReceive`	net6.0	1.31μs	0.659ns	2.47ns	0.0164	1.14 KB
master	`SendReceive`	netcoreapp3.1	1.71μs	1.84ns	7.12ns	0.0153	1.14 KB
master	`SendReceive`	net472	2.07μs	0.844ns	2.92ns	0.183	1.16 KB
#6484	`SendReceive`	net6.0	1.35μs	0.511ns	1.98ns	0.0162	1.14 KB
#6484	`SendReceive`	netcoreapp3.1	1.86μs	1.16ns	4.5ns	0.015	1.14 KB
#6484	`SendReceive`	net472	2.1μs	1.16ns	4.5ns	0.183	1.16 KB

Benchmarks.Trace.SerilogBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`EnrichedLog`	net6.0	2.71μs	0.7ns	2.71ns	0.0217	1.6 KB
master	`EnrichedLog`	netcoreapp3.1	3.81μs	1.59ns	5.95ns	0.0208	1.65 KB
master	`EnrichedLog`	net472	4.4μs	0.843ns	3.04ns	0.322	2.04 KB
#6484	`EnrichedLog`	net6.0	2.71μs	1ns	3.76ns	0.0229	1.6 KB
#6484	`EnrichedLog`	netcoreapp3.1	3.8μs	0.897ns	3.23ns	0.0209	1.65 KB
#6484	`EnrichedLog`	net472	4.4μs	3.17ns	11.9ns	0.324	2.04 KB

Benchmarks.Trace.SpanBenchmark - Slower ⚠️ Same allocations ✔️

Slower ⚠️ in #6484

Benchmark	diff/base	Base Median (ns)	Diff Median (ns)	Modality
Benchmarks.Trace.SpanBenchmark.StartFinishScope‑netcoreapp3.1	1.168	675.82	789.10

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`StartFinishSpan`	net6.0	399ns	0.25ns	0.967ns	0.00805	576 B
master	`StartFinishSpan`	netcoreapp3.1	597ns	0.33ns	1.28ns	0.00752	576 B
master	`StartFinishSpan`	net472	656ns	0.281ns	1.05ns	0.0917	578 B
master	`StartFinishScope`	net6.0	483ns	0.227ns	0.849ns	0.00965	696 B
master	`StartFinishScope`	netcoreapp3.1	676ns	0.441ns	1.71ns	0.00949	696 B
master	`StartFinishScope`	net472	872ns	0.728ns	2.82ns	0.104	658 B
#6484	`StartFinishSpan`	net6.0	389ns	0.164ns	0.634ns	0.00806	576 B
#6484	`StartFinishSpan`	netcoreapp3.1	563ns	0.728ns	2.82ns	0.00788	576 B
#6484	`StartFinishSpan`	net472	730ns	1.32ns	4.96ns	0.0917	578 B
#6484	`StartFinishScope`	net6.0	482ns	0.358ns	1.39ns	0.00974	696 B
#6484	`StartFinishScope`	netcoreapp3.1	789ns	0.799ns	3.09ns	0.00938	696 B
#6484	`StartFinishScope`	net472	875ns	0.395ns	1.53ns	0.104	658 B

Benchmarks.Trace.TraceAnnotationsBenchmark - Same speed ✔️ Same allocations ✔️

Raw results

Branch	Method	Toolchain	Mean	StdError	StdDev	Gen 0	Allocated
master	`RunOnMethodBegin`	net6.0	634ns	0.299ns	1.12ns	0.00988	696 B
master	`RunOnMethodBegin`	netcoreapp3.1	906ns	0.326ns	1.26ns	0.00898	696 B
master	`RunOnMethodBegin`	net472	1.07μs	0.503ns	1.95ns	0.104	658 B
#6484	`RunOnMethodBegin`	net6.0	659ns	0.419ns	1.62ns	0.00964	696 B
#6484	`RunOnMethodBegin`	netcoreapp3.1	1.01μs	1.48ns	5.73ns	0.00953	696 B
#6484	`RunOnMethodBegin`	net472	1.14μs	0.849ns	3.29ns	0.104	658 B

Update dotnet-install scripts

5b98953

andrewlock added area:builds project files, build scripts, pipelines, versioning, releases, packages status:do-not-merge Work is done. Can review, but do not merge yet. labels Dec 24, 2024

andrewlock requested a review from a team as a code owner December 24, 2024 13:22

kevingosse approved these changes Jan 2, 2025

View reviewed changes

lucaspimentel approved these changes Jan 6, 2025

View reviewed changes

lucaspimentel mentioned this pull request Jan 17, 2025

Point to the new domains / URLs from Microsoft in dotnet-install #6574

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update dotnet-install scripts for impending change of .NET install domains #6484

Update dotnet-install scripts for impending change of .NET install domains #6484

andrewlock commented Dec 24, 2024

datadog-ddstaging bot commented Dec 24, 2024 •

edited

Loading

andrewlock commented Dec 24, 2024

andrewlock commented Dec 24, 2024

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6484

Raw results

Raw results

Update dotnet-install scripts for impending change of .NET install domains #6484

Are you sure you want to change the base?

Update dotnet-install scripts for impending change of .NET install domains #6484

Conversation

andrewlock commented Dec 24, 2024

Summary of changes

Reason for change

Implementation details

Test coverage

Other details

datadog-ddstaging bot commented Dec 24, 2024 • edited Loading

Datadog Report

andrewlock commented Dec 24, 2024

Execution-Time Benchmarks Report ⏱️

andrewlock commented Dec 24, 2024

Benchmarks Report for tracer 🐌

Benchmark details

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Raw results

Slower ⚠️ in #6484

Raw results

Raw results

datadog-ddstaging bot commented Dec 24, 2024 •

edited

Loading