Export SamplingPriority method on spanContext [SVLS-3934] #2291
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Exports the
SamplingPriority
method on thespanContext
type.Motivation
We on the serverless team are working to update the Lambda Extension from doing manual trace context extraction to instead deferring to dd-trace-go for all extraction. This will allow us to be able to support W3C trace context headers.
The problem is that we also need to have access to the sampling priority. We must add this value to the trace chunk before it's processed by the trace agent.
Currently, dd-trace-go offers no way for us to get access to the sampling priority.
Discussion
I am very much open to discussion for how best to get the sampling priority from the
SpanContext
. I have chosen to simply export theSamplingPriority
method because it's the lightest touch creating a small diff. Furthermore, the exported method will not show up in godocs and therefore not be immediately visible to users. One would have to read the code and specifically cast theSpanContext
to a new interface to get access to it.Here's how I'm proposing to use the method:
Reviewer's Checklist
For Datadog employees:
@DataDog/security-design-and-guidance
.Unsure? Have a question? Request a review!