-
Notifications
You must be signed in to change notification settings - Fork 283
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AppSec Xml support for play 2.6 #6100
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 0 performance regressions! Performance is the same for 53 cases.
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.23.0-SNAPSHOT~7966052880, baseline=1.23.0-SNAPSHOT~29753c57f8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.024 s) : 0, 1023934
Total [baseline] (9.282 s) : 0, 9281569
Agent [candidate] (1.028 s) : 0, 1027971
Total [candidate] (9.323 s) : 0, 9323126
section appsec
Agent [baseline] (1.112 s) : 0, 1112343
Total [baseline] (9.359 s) : 0, 9358964
Agent [candidate] (1.135 s) : 0, 1135302
Total [candidate] (9.411 s) : 0, 9410847
section iast
Agent [baseline] (1.162 s) : 0, 1162445
Total [baseline] (9.514 s) : 0, 9514061
Agent [candidate] (1.158 s) : 0, 1158014
Total [candidate] (9.527 s) : 0, 9527010
section profiling
Agent [baseline] (1.208 s) : 0, 1208073
Total [baseline] (9.556 s) : 0, 9555754
Agent [candidate] (1.213 s) : 0, 1212628
Total [candidate] (9.624 s) : 0, 9623666
gantt
title petclinic - break down per module: candidate=1.23.0-SNAPSHOT~7966052880, baseline=1.23.0-SNAPSHOT~29753c57f8
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (639.936 ms) : 0, 639936
BytebuddyAgent [candidate] (642.956 ms) : 0, 642956
GlobalTracer [baseline] (293.787 ms) : 0, 293787
GlobalTracer [candidate] (294.843 ms) : 0, 294843
AppSec [baseline] (49.049 ms) : 0, 49049
AppSec [candidate] (48.83 ms) : 0, 48830
Remote Config [baseline] (680.349 µs) : 0, 680
Remote Config [candidate] (692.108 µs) : 0, 692
Telemetry [baseline] (6.071 ms) : 0, 6071
Telemetry [candidate] (6.083 ms) : 0, 6083
section appsec
BytebuddyAgent [baseline] (640.29 ms) : 0, 640290
BytebuddyAgent [candidate] (654.351 ms) : 0, 654351
GlobalTracer [baseline] (292.586 ms) : 0, 292586
GlobalTracer [candidate] (299.135 ms) : 0, 299135
AppSec [baseline] (138.613 ms) : 0, 138613
AppSec [candidate] (140.141 ms) : 0, 140141
Remote Config [baseline] (642.379 µs) : 0, 642
Remote Config [candidate] (660.188 µs) : 0, 660
Telemetry [baseline] (5.721 ms) : 0, 5721
Telemetry [candidate] (5.842 ms) : 0, 5842
section iast
BytebuddyAgent [baseline] (778.23 ms) : 0, 778230
BytebuddyAgent [candidate] (775.104 ms) : 0, 775104
GlobalTracer [baseline] (275.733 ms) : 0, 275733
GlobalTracer [candidate] (275.089 ms) : 0, 275089
AppSec [baseline] (49.335 ms) : 0, 49335
AppSec [candidate] (48.232 ms) : 0, 48232
Remote Config [baseline] (563.168 µs) : 0, 563
Remote Config [candidate] (1.242 ms) : 0, 1242
Telemetry [baseline] (7.612 ms) : 0, 7612
Telemetry [candidate] (8.35 ms) : 0, 8350
IAST [baseline] (16.176 ms) : 0, 16176
IAST [candidate] (15.346 ms) : 0, 15346
section profiling
ProfilingAgent [baseline] (80.729 ms) : 0, 80729
ProfilingAgent [candidate] (81.792 ms) : 0, 81792
BytebuddyAgent [baseline] (656.463 ms) : 0, 656463
BytebuddyAgent [candidate] (658.963 ms) : 0, 658963
GlobalTracer [baseline] (360.396 ms) : 0, 360396
GlobalTracer [candidate] (361.321 ms) : 0, 361321
AppSec [baseline] (50.067 ms) : 0, 50067
AppSec [candidate] (49.955 ms) : 0, 49955
Remote Config [baseline] (653.069 µs) : 0, 653
Remote Config [candidate] (654.396 µs) : 0, 654
Telemetry [baseline] (6.079 ms) : 0, 6079
Telemetry [candidate] (6.14 ms) : 0, 6140
Profiling [baseline] (80.754 ms) : 0, 80754
Profiling [candidate] (81.816 ms) : 0, 81816
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.23.0-SNAPSHOT~7966052880, baseline=1.23.0-SNAPSHOT~29753c57f8
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (1.026 s) : 0, 1025597
Total [baseline] (8.733 s) : 0, 8733301
Agent [candidate] (1.028 s) : 0, 1028340
Total [candidate] (8.751 s) : 0, 8750820
section iast
Agent [baseline] (1.152 s) : 0, 1151513
Total [baseline] (9.304 s) : 0, 9303561
Agent [candidate] (1.152 s) : 0, 1151516
Total [candidate] (9.261 s) : 0, 9260947
section iast_TELEMETRY_OFF
Agent [baseline] (1.152 s) : 0, 1152480
Total [baseline] (9.273 s) : 0, 9273085
Agent [candidate] (1.148 s) : 0, 1147868
Total [candidate] (9.242 s) : 0, 9242403
gantt
title insecure-bank - break down per module: candidate=1.23.0-SNAPSHOT~7966052880, baseline=1.23.0-SNAPSHOT~29753c57f8
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (640.976 ms) : 0, 640976
BytebuddyAgent [candidate] (642.972 ms) : 0, 642972
GlobalTracer [baseline] (294.049 ms) : 0, 294049
GlobalTracer [candidate] (294.692 ms) : 0, 294692
AppSec [baseline] (49.385 ms) : 0, 49385
AppSec [candidate] (49.448 ms) : 0, 49448
Remote Config [baseline] (680.943 µs) : 0, 681
Remote Config [candidate] (684.494 µs) : 0, 684
Telemetry [baseline] (6.042 ms) : 0, 6042
Telemetry [candidate] (6.144 ms) : 0, 6144
section iast
BytebuddyAgent [baseline] (770.244 ms) : 0, 770244
BytebuddyAgent [candidate] (770.042 ms) : 0, 770042
GlobalTracer [baseline] (272.819 ms) : 0, 272819
GlobalTracer [candidate] (273.968 ms) : 0, 273968
AppSec [baseline] (46.299 ms) : 0, 46299
AppSec [candidate] (47.073 ms) : 0, 47073
Remote Config [baseline] (575.339 µs) : 0, 575
Remote Config [candidate] (612.735 µs) : 0, 613
Telemetry [baseline] (9.707 ms) : 0, 9707
Telemetry [candidate] (6.134 ms) : 0, 6134
IAST [baseline] (17.467 ms) : 0, 17467
IAST [candidate] (19.281 ms) : 0, 19281
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (770.424 ms) : 0, 770424
BytebuddyAgent [candidate] (766.707 ms) : 0, 766707
GlobalTracer [baseline] (275.143 ms) : 0, 275143
GlobalTracer [candidate] (274.746 ms) : 0, 274746
AppSec [baseline] (46.753 ms) : 0, 46753
AppSec [candidate] (46.805 ms) : 0, 46805
Remote Config [baseline] (567.407 µs) : 0, 567
Remote Config [candidate] (579.039 µs) : 0, 579
Telemetry [baseline] (7.719 ms) : 0, 7719
Telemetry [candidate] (6.116 ms) : 0, 6116
IAST [baseline] (17.123 ms) : 0, 17123
IAST [candidate] (18.241 ms) : 0, 18241
LoadParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 22 cases. Request duration reports for petclinicgantt
title petclinic - request duration [CI 0.99] : candidate=1.23.0-SNAPSHOT~7966052880, baseline=1.23.0-SNAPSHOT~29753c57f8
dateFormat X
axisFormat %s
section baseline
no_agent (1.351 ms) : 1331, 1370
. : milestone, 1351,
appsec (1.713 ms) : 1689, 1737
. : milestone, 1713,
iast (1.478 ms) : 1454, 1503
. : milestone, 1478,
profiling (1.469 ms) : 1444, 1494
. : milestone, 1469,
tracing (1.449 ms) : 1425, 1474
. : milestone, 1449,
section candidate
no_agent (1.343 ms) : 1323, 1362
. : milestone, 1343,
appsec (1.71 ms) : 1685, 1734
. : milestone, 1710,
iast (1.455 ms) : 1431, 1479
. : milestone, 1455,
profiling (1.437 ms) : 1413, 1462
. : milestone, 1437,
tracing (1.458 ms) : 1433, 1483
. : milestone, 1458,
Request duration reports for insecure-bankgantt
title insecure-bank - request duration [CI 0.99] : candidate=1.23.0-SNAPSHOT~7966052880, baseline=1.23.0-SNAPSHOT~29753c57f8
dateFormat X
axisFormat %s
section baseline
no_agent (364.047 µs) : 343, 385
. : milestone, 364,
iast (468.088 µs) : 447, 489
. : milestone, 468,
iast_FULL (522.962 µs) : 502, 544
. : milestone, 523,
iast_INACTIVE (428.425 µs) : 408, 449
. : milestone, 428,
iast_TELEMETRY_OFF (453.901 µs) : 433, 475
. : milestone, 454,
tracing (435.952 µs) : 414, 458
. : milestone, 436,
section candidate
no_agent (372.736 µs) : 352, 393
. : milestone, 373,
iast (458.892 µs) : 438, 479
. : milestone, 459,
iast_FULL (521.366 µs) : 500, 542
. : milestone, 521,
iast_INACTIVE (434.382 µs) : 414, 455
. : milestone, 434,
iast_TELEMETRY_OFF (462.297 µs) : 440, 484
. : milestone, 462,
tracing (432.061 µs) : 411, 453
. : milestone, 432,
|
smola
approved these changes
Oct 26, 2023
cataphract
force-pushed
the
glopes/play-2.6-xml
branch
from
October 27, 2023 05:49
c639818
to
bfb5757
Compare
cataphract
force-pushed
the
glopes/play-2.6-xml
branch
from
October 27, 2023 05:58
bfb5757
to
7966052
Compare
5 tasks
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.