Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Switch to 128-bit trace ID tracking #7259

Merged
merged 3 commits into from
Jul 30, 2024
Merged

Switch to 128-bit trace ID tracking #7259

merged 3 commits into from
Jul 30, 2024

Conversation

spikat
Copy link
Contributor

@spikat spikat commented Jun 28, 2024 •
edited
Loading

What Does This Do

It switches used trace IDs to 128 bits.

Motivation

Be compliant with the new tracer

Additional Notes

Jira ticket: [PROJ-IDENT]

@spikat spikat added the comp: cws Cloud Workload Security (CWS) label Jun 28, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jun 28, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jrs/use-128bits-span-trace-ids
git_commit_date 1720794919 1720796892
git_commit_sha 0e5e274 2b911e8
release_version 1.38.0-SNAPSHOT~0e5e2749b0 1.38.0-SNAPSHOT~2b911e801d
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720799409 1720799409
ci_job_id 571047056 571047056
ci_pipeline_id 39048143 39048143
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 55 metrics, 8 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~2b911e801d, baseline=1.38.0-SNAPSHOT~0e5e2749b0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.064 s) : 0, 1063738
Total [baseline] (8.519 s) : 0, 8518786
Agent [candidate] (1.063 s) : 0, 1062783
Total [candidate] (8.502 s) : 0, 8501603
section iast
Agent [baseline] (1.182 s) : 0, 1181861
Total [baseline] (8.979 s) : 0, 8979402
Agent [candidate] (1.208 s) : 0, 1207789
Total [candidate] (8.984 s) : 0, 8983949
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.172 s) : 0, 1171867
Total [baseline] (8.91 s) : 0, 8909747
Agent [candidate] (1.175 s) : 0, 1174754
Total [candidate] (8.911 s) : 0, 8910946
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1170338
Total [baseline] (8.957 s) : 0, 8957356
Agent [candidate] (1.183 s) : 0, 1182866
Total [candidate] (8.992 s) : 0, 8991875
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.064 s -
Agent iast 1.182 s 118.123 ms (11.1%)
Agent iast_HARDCODED_SECRET_DISABLED 1.172 s 108.128 ms (10.2%)
Agent iast_TELEMETRY_OFF 1.17 s 106.599 ms (10.0%)
Total tracing 8.519 s -
Total iast 8.979 s 460.616 ms (5.4%)
Total iast_HARDCODED_SECRET_DISABLED 8.91 s 390.961 ms (4.6%)
Total iast_TELEMETRY_OFF 8.957 s 438.57 ms (5.1%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent iast 1.208 s 145.007 ms (13.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.175 s 111.972 ms (10.5%)
Agent iast_TELEMETRY_OFF 1.183 s 120.084 ms (11.3%)
Total tracing 8.502 s -
Total iast 8.984 s 482.346 ms (5.7%)
Total iast_HARDCODED_SECRET_DISABLED 8.911 s 409.343 ms (4.8%)
Total iast_TELEMETRY_OFF 8.992 s 490.272 ms (5.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~2b911e801d, baseline=1.38.0-SNAPSHOT~0e5e2749b0

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (665.865 ms) : 0, 665865
BytebuddyAgent [candidate] (664.794 ms) : 0, 664794
GlobalTracer [baseline] (305.178 ms) : 0, 305178
GlobalTracer [candidate] (305.182 ms) : 0, 305182
AppSec [baseline] (49.931 ms) : 0, 49931
AppSec [candidate] (50.085 ms) : 0, 50085
Remote Config [baseline] (665.504 µs) : 0, 666
Remote Config [candidate] (672.205 µs) : 0, 672
Telemetry [baseline] (7.569 ms) : 0, 7569
Telemetry [candidate] (7.609 ms) : 0, 7609
section iast
BytebuddyAgent [baseline] (787.025 ms) : 0, 787025
BytebuddyAgent [candidate] (806.472 ms) : 0, 806472
GlobalTracer [baseline] (297.691 ms) : 0, 297691
GlobalTracer [candidate] (304.01 ms) : 0, 304010
AppSec [baseline] (49.979 ms) : 0, 49979
AppSec [candidate] (49.473 ms) : 0, 49473
IAST [baseline] (26.049 ms) : 0, 26049
IAST [candidate] (26.139 ms) : 0, 26139
Remote Config [baseline] (580.898 µs) : 0, 581
Remote Config [candidate] (596.735 µs) : 0, 597
Telemetry [baseline] (6.979 ms) : 0, 6979
Telemetry [candidate] (7.213 ms) : 0, 7213
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (779.591 ms) : 0, 779591
BytebuddyAgent [candidate] (781.318 ms) : 0, 781318
GlobalTracer [baseline] (295.129 ms) : 0, 295129
GlobalTracer [candidate] (296.797 ms) : 0, 296797
AppSec [baseline] (48.09 ms) : 0, 48090
AppSec [candidate] (47.527 ms) : 0, 47527
IAST [baseline] (27.947 ms) : 0, 27947
IAST [candidate] (28.033 ms) : 0, 28033
Remote Config [baseline] (569.52 µs) : 0, 570
Remote Config [candidate] (573.21 µs) : 0, 573
Telemetry [baseline] (6.985 ms) : 0, 6985
Telemetry [candidate] (6.977 ms) : 0, 6977
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (778.777 ms) : 0, 778777
BytebuddyAgent [candidate] (788.532 ms) : 0, 788532
GlobalTracer [baseline] (295.958 ms) : 0, 295958
GlobalTracer [candidate] (299.547 ms) : 0, 299547
AppSec [baseline] (47.313 ms) : 0, 47313
AppSec [candidate] (47.9 ms) : 0, 47900
IAST [baseline] (27.429 ms) : 0, 27429
IAST [candidate] (25.548 ms) : 0, 25548
Remote Config [baseline] (567.224 µs) : 0, 567
Remote Config [candidate] (603.673 µs) : 0, 604
Telemetry [baseline] (6.779 ms) : 0, 6779
Telemetry [candidate] (7.068 ms) : 0, 7068
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~2b911e801d, baseline=1.38.0-SNAPSHOT~0e5e2749b0

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.069 s) : 0, 1069158
Total [baseline] (10.36 s) : 0, 10359601
Agent [candidate] (1.071 s) : 0, 1070972
Total [candidate] (10.358 s) : 0, 10357701
section appsec
Agent [baseline] (1.186 s) : 0, 1185521
Total [baseline] (10.551 s) : 0, 10550844
Agent [candidate] (1.183 s) : 0, 1182519
Total [candidate] (10.497 s) : 0, 10497107
section iast
Agent [baseline] (1.201 s) : 0, 1201049
Total [baseline] (10.737 s) : 0, 10736571
Agent [candidate] (1.172 s) : 0, 1172001
Total [candidate] (10.686 s) : 0, 10686118
section profiling
Agent [baseline] (1.268 s) : 0, 1268073
Total [baseline] (10.556 s) : 0, 10556055
Agent [candidate] (1.267 s) : 0, 1266969
Total [candidate] (10.579 s) : 0, 10578980
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.069 s -
Agent appsec 1.186 s 116.363 ms (10.9%)
Agent iast 1.201 s 131.891 ms (12.3%)
Agent profiling 1.268 s 198.916 ms (18.6%)
Total tracing 10.36 s -
Total appsec 10.551 s 191.243 ms (1.8%)
Total iast 10.737 s 376.97 ms (3.6%)
Total profiling 10.556 s 196.453 ms (1.9%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent appsec 1.183 s 111.547 ms (10.4%)
Agent iast 1.172 s 101.029 ms (9.4%)
Agent profiling 1.267 s 195.997 ms (18.3%)
Total tracing 10.358 s -
Total appsec 10.497 s 139.406 ms (1.3%)
Total iast 10.686 s 328.417 ms (3.2%)
Total profiling 10.579 s 221.279 ms (2.1%) 
gantt
    title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~2b911e801d, baseline=1.38.0-SNAPSHOT~0e5e2749b0

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (669.119 ms) : 0, 669119
BytebuddyAgent [candidate] (670.5 ms) : 0, 670500
GlobalTracer [baseline] (306.69 ms) : 0, 306690
GlobalTracer [candidate] (307.209 ms) : 0, 307209
AppSec [baseline] (50.33 ms) : 0, 50330
AppSec [candidate] (50.141 ms) : 0, 50141
Remote Config [baseline] (681.052 µs) : 0, 681
Remote Config [candidate] (674.697 µs) : 0, 675
Telemetry [baseline] (7.65 ms) : 0, 7650
Telemetry [candidate] (7.646 ms) : 0, 7646
section appsec
BytebuddyAgent [baseline] (677.073 ms) : 0, 677073
BytebuddyAgent [candidate] (676.299 ms) : 0, 676299
GlobalTracer [baseline] (300.231 ms) : 0, 300231
GlobalTracer [candidate] (298.975 ms) : 0, 298975
AppSec [baseline] (153.551 ms) : 0, 153551
AppSec [candidate] (153.926 ms) : 0, 153926
Remote Config [baseline] (620.669 µs) : 0, 621
Remote Config [candidate] (620.855 µs) : 0, 621
Telemetry [baseline] (8.626 ms) : 0, 8626
Telemetry [candidate] (8.259 ms) : 0, 8259
IAST [baseline] (21.564 ms) : 0, 21564
IAST [candidate] (19.589 ms) : 0, 19589
section iast
BytebuddyAgent [baseline] (800.534 ms) : 0, 800534
BytebuddyAgent [candidate] (779.009 ms) : 0, 779009
GlobalTracer [baseline] (302.768 ms) : 0, 302768
GlobalTracer [candidate] (295.624 ms) : 0, 295624
AppSec [baseline] (48.909 ms) : 0, 48909
AppSec [candidate] (47.436 ms) : 0, 47436
Remote Config [baseline] (604.564 µs) : 0, 605
Remote Config [candidate] (572.477 µs) : 0, 572
Telemetry [baseline] (7.253 ms) : 0, 7253
Telemetry [candidate] (6.914 ms) : 0, 6914
IAST [baseline] (27.181 ms) : 0, 27181
IAST [candidate] (28.94 ms) : 0, 28940
section profiling
BytebuddyAgent [baseline] (665.029 ms) : 0, 665029
BytebuddyAgent [candidate] (664.122 ms) : 0, 664122
GlobalTracer [baseline] (389.543 ms) : 0, 389543
GlobalTracer [candidate] (389.322 ms) : 0, 389322
AppSec [baseline] (51.962 ms) : 0, 51962
AppSec [candidate] (51.942 ms) : 0, 51942
Remote Config [baseline] (656.42 µs) : 0, 656
Remote Config [candidate] (650.309 µs) : 0, 650
Telemetry [baseline] (7.394 ms) : 0, 7394
Telemetry [candidate] (7.353 ms) : 0, 7353
ProfilingAgent [baseline] (96.197 ms) : 0, 96197
ProfilingAgent [candidate] (96.32 ms) : 0, 96320
Profiling [baseline] (96.221 ms) : 0, 96221
Profiling [candidate] (96.345 ms) : 0, 96345
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-07-12T15:20:59 2024-07-12T15:27:51
git_branch master jrs/use-128bits-span-trace-ids
git_commit_date 1720794919 1720796892
git_commit_sha 0e5e274 2b911e8
release_version 1.38.0-SNAPSHOT~0e5e2749b0 1.38.0-SNAPSHOT~2b911e801d
start_time 2024-07-12T15:20:46 2024-07-12T15:27:37
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720798419 1720798419
ci_job_id 571047057 571047057
ci_pipeline_id 39048143 39048143
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 16 unstable metrics.

Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~2b911e801d, baseline=1.38.0-SNAPSHOT~0e5e2749b0
    dateFormat X
    axisFormat %s
section baseline
no_agent (366.142 µs) : 346, 386
.   : milestone, 366,
iast (494.761 µs) : 473, 516
.   : milestone, 495,
iast_FULL (554.379 µs) : 533, 576
.   : milestone, 554,
iast_GLOBAL (524.82 µs) : 502, 548
.   : milestone, 525,
iast_HARDCODED_SECRET_DISABLED (491.572 µs) : 470, 513
.   : milestone, 492,
iast_INACTIVE (458.295 µs) : 436, 480
.   : milestone, 458,
iast_TELEMETRY_OFF (472.71 µs) : 452, 494
.   : milestone, 473,
tracing (444.316 µs) : 424, 465
.   : milestone, 444,
section candidate
no_agent (367.974 µs) : 348, 388
.   : milestone, 368,
iast (485.388 µs) : 465, 506
.   : milestone, 485,
iast_FULL (557.593 µs) : 536, 579
.   : milestone, 558,
iast_GLOBAL (519.827 µs) : 497, 543
.   : milestone, 520,
iast_HARDCODED_SECRET_DISABLED (487.469 µs) : 466, 509
.   : milestone, 487,
iast_INACTIVE (457.279 µs) : 436, 478
.   : milestone, 457,
iast_TELEMETRY_OFF (481.053 µs) : 460, 503
.   : milestone, 481,
tracing (444.318 µs) : 424, 465
.   : milestone, 444,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.142 µs [346.378 µs, 385.907 µs] -
iast 494.761 µs [473.367 µs, 516.154 µs] 128.618 µs (35.1%)
iast_FULL 554.379 µs [533.23 µs, 575.527 µs] 188.236 µs (51.4%)
iast_GLOBAL 524.82 µs [502.119 µs, 547.521 µs] 158.677 µs (43.3%)
iast_HARDCODED_SECRET_DISABLED 491.572 µs [470.104 µs, 513.04 µs] 125.43 µs (34.3%)
iast_INACTIVE 458.295 µs [436.417 µs, 480.173 µs] 92.152 µs (25.2%)
iast_TELEMETRY_OFF 472.71 µs [451.66 µs, 493.76 µs] 106.568 µs (29.1%)
tracing 444.316 µs [423.809 µs, 464.823 µs] 78.174 µs (21.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 367.974 µs [348.232 µs, 387.716 µs] -
iast 485.388 µs [464.597 µs, 506.179 µs] 117.414 µs (31.9%)
iast_FULL 557.593 µs [536.211 µs, 578.975 µs] 189.619 µs (51.5%)
iast_GLOBAL 519.827 µs [496.561 µs, 543.092 µs] 151.852 µs (41.3%)
iast_HARDCODED_SECRET_DISABLED 487.469 µs [465.978 µs, 508.959 µs] 119.495 µs (32.5%)
iast_INACTIVE 457.279 µs [436.471 µs, 478.088 µs] 89.305 µs (24.3%)
iast_TELEMETRY_OFF 481.053 µs [459.516 µs, 502.59 µs] 113.079 µs (30.7%)
tracing 444.318 µs [424.112 µs, 464.525 µs] 76.344 µs (20.7%)
Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~2b911e801d, baseline=1.38.0-SNAPSHOT~0e5e2749b0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.347 ms) : 1327, 1366
.   : milestone, 1347,
appsec (1.704 ms) : 1680, 1727
.   : milestone, 1704,
appsec_no_iast (1.732 ms) : 1709, 1756
.   : milestone, 1732,
iast (1.498 ms) : 1476, 1519
.   : milestone, 1498,
profiling (1.507 ms) : 1480, 1533
.   : milestone, 1507,
tracing (1.485 ms) : 1462, 1509
.   : milestone, 1485,
section candidate
no_agent (1.342 ms) : 1320, 1364
.   : milestone, 1342,
appsec (1.73 ms) : 1707, 1753
.   : milestone, 1730,
appsec_no_iast (1.743 ms) : 1720, 1767
.   : milestone, 1743,
iast (1.498 ms) : 1475, 1520
.   : milestone, 1498,
profiling (1.552 ms) : 1527, 1577
.   : milestone, 1552,
tracing (1.466 ms) : 1441, 1491
.   : milestone, 1466,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.347 ms [1.327 ms, 1.366 ms] -
appsec 1.704 ms [1.68 ms, 1.727 ms] 356.815 µs (26.5%)
appsec_no_iast 1.732 ms [1.709 ms, 1.756 ms] 385.615 µs (28.6%)
iast 1.498 ms [1.476 ms, 1.519 ms] 150.862 µs (11.2%)
profiling 1.507 ms [1.48 ms, 1.533 ms] 159.786 µs (11.9%)
tracing 1.485 ms [1.462 ms, 1.509 ms] 138.669 µs (10.3%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.342 ms [1.32 ms, 1.364 ms] -
appsec 1.73 ms [1.707 ms, 1.753 ms] 388.498 µs (29.0%)
appsec_no_iast 1.743 ms [1.72 ms, 1.767 ms] 401.542 µs (29.9%)
iast 1.498 ms [1.475 ms, 1.52 ms] 155.96 µs (11.6%)
profiling 1.552 ms [1.527 ms, 1.577 ms] 210.11 µs (15.7%)
tracing 1.466 ms [1.441 ms, 1.491 ms] 124.027 µs (9.2%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master jrs/use-128bits-span-trace-ids
git_commit_date 1720794919 1720796892
git_commit_sha 0e5e274 2b911e8
release_version 1.38.0-SNAPSHOT~0e5e2749b0 1.38.0-SNAPSHOT~2b911e801d
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1720798913 1720798913
ci_job_id 571047058 571047058
ci_pipeline_id 39048143 39048143
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 1 unstable metrics.

Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~2b911e801d, baseline=1.38.0-SNAPSHOT~0e5e2749b0
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.464 ms) : 1452, 1475
.   : milestone, 1464,
appsec (2.225 ms) : 2190, 2260
.   : milestone, 2225,
iast (1.984 ms) : 1942, 2026
.   : milestone, 1984,
iast_GLOBAL (2.005 ms) : 1963, 2048
.   : milestone, 2005,
profiling (2.359 ms) : 2171, 2548
.   : milestone, 2359,
tracing (1.844 ms) : 1811, 1877
.   : milestone, 1844,
section candidate
no_agent (1.465 ms) : 1453, 1476
.   : milestone, 1465,
appsec (2.228 ms) : 2193, 2262
.   : milestone, 2228,
iast (1.97 ms) : 1928, 2011
.   : milestone, 1970,
iast_GLOBAL (2.017 ms) : 1975, 2059
.   : milestone, 2017,
profiling (1.868 ms) : 1834, 1902
.   : milestone, 1868,
tracing (1.837 ms) : 1804, 1870
.   : milestone, 1837,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.452 ms, 1.475 ms] -
appsec 2.225 ms [2.19 ms, 2.26 ms] 761.686 µs (52.0%)
iast 1.984 ms [1.942 ms, 2.026 ms] 520.118 µs (35.5%)
iast_GLOBAL 2.005 ms [1.963 ms, 2.048 ms] 541.432 µs (37.0%)
profiling 2.359 ms [2.171 ms, 2.548 ms] 895.567 µs (61.2%)
tracing 1.844 ms [1.811 ms, 1.877 ms] 380.774 µs (26.0%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.465 ms [1.453 ms, 1.476 ms] -
appsec 2.228 ms [2.193 ms, 2.262 ms] 763.193 µs (52.1%)
iast 1.97 ms [1.928 ms, 2.011 ms] 505.229 µs (34.5%)
iast_GLOBAL 2.017 ms [1.975 ms, 2.059 ms] 551.989 µs (37.7%)
profiling 1.868 ms [1.834 ms, 1.902 ms] 403.705 µs (27.6%)
tracing 1.837 ms [1.804 ms, 1.87 ms] 372.303 µs (25.4%)
Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~2b911e801d, baseline=1.38.0-SNAPSHOT~0e5e2749b0
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.448 s) : 15448000, 15448000
.   : milestone, 15448000,
appsec (14.844 s) : 14844000, 14844000
.   : milestone, 14844000,
iast (18.852 s) : 18852000, 18852000
.   : milestone, 18852000,
iast_GLOBAL (18.016 s) : 18016000, 18016000
.   : milestone, 18016000,
profiling (15.437 s) : 15437000, 15437000
.   : milestone, 15437000,
tracing (14.941 s) : 14941000, 14941000
.   : milestone, 14941000,
section candidate
no_agent (15.273 s) : 15273000, 15273000
.   : milestone, 15273000,
appsec (14.928 s) : 14928000, 14928000
.   : milestone, 14928000,
iast (18.571 s) : 18571000, 18571000
.   : milestone, 18571000,
iast_GLOBAL (17.902 s) : 17902000, 17902000
.   : milestone, 17902000,
profiling (15.7 s) : 15700000, 15700000
.   : milestone, 15700000,
tracing (14.983 s) : 14983000, 14983000
.   : milestone, 14983000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.448 s [15.448 s, 15.448 s] -
appsec 14.844 s [14.844 s, 14.844 s] -604.0 ms (-3.9%)
iast 18.852 s [18.852 s, 18.852 s] 3.404 s (22.0%)
iast_GLOBAL 18.016 s [18.016 s, 18.016 s] 2.568 s (16.6%)
profiling 15.437 s [15.437 s, 15.437 s] -11.0 ms (-0.1%)
tracing 14.941 s [14.941 s, 14.941 s] -507.0 ms (-3.3%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.273 s [15.273 s, 15.273 s] -
appsec 14.928 s [14.928 s, 14.928 s] -345.0 ms (-2.3%)
iast 18.571 s [18.571 s, 18.571 s] 3.298 s (21.6%)
iast_GLOBAL 17.902 s [17.902 s, 17.902 s] 2.629 s (17.2%)
profiling 15.7 s [15.7 s, 15.7 s] 427.0 ms (2.8%)
tracing 14.983 s [14.983 s, 14.983 s] -290.0 ms (-1.9%)

@spikat spikat changed the title [CWS] Swith to 128bits for the traceID and prepare the span switch as well [CWS] Swith to 128bits for the traceID Jul 9, 2024
@spikat spikat force-pushed the jrs/use-128bits-span-trace-ids branch from 7dd5abb to da07a8c Compare July 9, 2024 07:54
@spikat spikat mentioned this pull request Jul 9, 2024
Merged
@spikat spikat marked this pull request as ready for review July 9, 2024 09:47
@spikat spikat requested a review from a team as a code owner July 9, 2024 09:47
@spikat spikat requested review from dougqh and ygree July 9, 2024 09:47
PerfectSlayer
PerfectSlayer reviewed Jul 11, 2024
View reviewed changes
Copy link
Contributor

@PerfectSlayer PerfectSlayer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a minor comment.
It might be nice to have some tests mixing 64 and 128b TID 🤷

@PerfectSlayer PerfectSlayer changed the title [CWS] Swith to 128bits for the traceID Switch to 128-bit trace ID tracking Jul 11, 2024
@spikat spikat force-pushed the jrs/use-128bits-span-trace-ids branch from 2b911e8 to fdaefc3 Compare July 30, 2024 15:26
@spikat spikat merged commit 7028eaf into master Jul 30, 2024
77 of 79 checks passed
@spikat spikat deleted the jrs/use-128bits-span-trace-ids branch July 30, 2024 16:08
@github-actions github-actions bot added this to the 1.38.0 milestone Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PerfectSlayer PerfectSlayer PerfectSlayer approved these changes

@dougqh dougqh dougqh approved these changes

@ygree ygree ygree approved these changes

Assignees
No one assigned
Labels
comp: cws Cloud Workload Security (CWS)
Projects
None yet
Milestone
1.38.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@spikat @dougqh @PerfectSlayer @ygree