Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix service version and sanitize tags #7293

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Fix service version and sanitize tags #7293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2e0f8aa
Sanitize service env and version in SymbolSink
ojung Jul 9, 2024
b50a8e3
Remove duplicate tests
ojung Jul 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dd-java-agent/agent-debugger/src/main/java/com/datadog/debugger/sink/SymbolSink.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,8 +45,8 @@ public SymbolSink(Config config) {

SymbolSink(Config config, BatchUploader symbolUploader) {
this.serviceName = TagsHelper.sanitize(config.getServiceName());
this.env = config.getEnv();
this.version = config.getVersion();
this.env = TagsHelper.sanitize(config.getEnv());
this.version = TagsHelper.sanitize(config.getVersion());
this.symbolUploader = symbolUploader;
byte[] eventContent =
String.format(
Expand Down
2 changes: 0 additions & 2 deletions ...-agent/agent-debugger/src/test/java/com/datadog/debugger/util/ClassNameFilteringTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,11 +79,9 @@ public void testIncludeSomeExcludeSome() {
strings = {
"java.FooBar",
"org.junit.Test",
"org.junit.jupiter.api.Test",
"akka.Actor",
"cats.Functor",
"org.junit.jupiter.api.Test",
"org.junit.jupiter.api.Test",
"org.datadog.jmxfetch.FooBar"
})
public void testExcludeDefaults(String input) {
Expand Down
Loading