Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix service version and sanitize tags #7293

Merged
merged 2 commits into from
Jul 9, 2024
Merged

Fix service version and sanitize tags #7293

merged 2 commits into from
Jul 9, 2024

Conversation

ojung
Copy link
Contributor

@ojung ojung commented Jul 9, 2024

What Does This Do

Sanitizes env and version in SymbolSink.

Motivation

We're matching RC tags with these tags, so they have to be sanitized the same way.

dd-trace-java/remote-config/src/main/java/datadog/remoteconfig/PollerRequestFactory.java

Lines 54 to 57 in 65d7de1

this.serviceName = TagsHelper.sanitize(config.getServiceName());
this.apiKey = config.getApiKey();
this.env = TagsHelper.sanitize(config.getEnv());
this.ddVersion = TagsHelper.sanitize(config.getVersion());

Additional Notes

Jira ticket: [PROJ-IDENT]

@ojung ojung requested a review from a team as a code owner July 9, 2024 07:23
@ojung ojung requested review from jpbempel and removed request for a team July 9, 2024 07:23
@ojung ojung changed the title Ojung/debug 2504 fix service version sanitize tags Fix service version sanitize tags Jul 9, 2024
@pr-commenter
Copy link

pr-commenter bot commented Jul 9, 2024 •
edited
Loading

Debugger benchmarks

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
ci_job_date 1720514960 1720515369
end_time 2024-07-09T08:50:33 2024-07-09T08:57:23
git_branch master ojung/DEBUG-2504-fix-service-version-sanitize-tags
git_commit_sha 9e7aa67 b50a8e3
start_time 2024-07-09T08:49:21 2024-07-09T08:56:10
See matching parameters
Baseline Candidate
ci_job_id 566184362 566184362
ci_pipeline_id 38675192 38675192
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
git_commit_date 1720514320 1720514320

Summary

Found 5 performance improvements and 0 performance regressions! Performance is the same for 4 metrics, 6 unstable metrics.

scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:loop better
[-667.020µs; -653.961µs] or [-5.625%; -5.515%]		 better
[-711.133µs; -617.620µs] or [-5.912%; -5.134%]		 better
[-768.190µs; -599.406µs] or [-6.329%; -4.939%]		 better
[-995.275µs; -413.920µs] or [-7.878%; -3.276%]		 better
[+3.882op/s; +5.422op/s] or [+4.717%; +6.587%]
See unchanged results
scenario Δ mean agg_http_req_duration_min Δ mean agg_http_req_duration_p50 Δ mean agg_http_req_duration_p75 Δ mean agg_http_req_duration_p99 Δ mean throughput
scenario:noprobe unstable
[-10.782µs; +39.318µs] or [-4.310%; +15.718%]		 unstable
[-21.569µs; +53.901µs] or [-7.572%; +18.922%]		 unstable
[-31.307µs; +66.314µs] or [-10.529%; +22.303%]		 unstable
[-74.504µs; +109.686µs] or [-11.628%; +17.119%]		 same
scenario:basic unsure
[-12.927µs; -0.964µs] or [-4.695%; -0.350%]		 same same unstable
[-44.570µs; +35.448µs] or [-7.409%; +5.893%]		 unstable
[-172.427op/s; +172.478op/s] or [-6.725%; +6.727%]
Request duration reports for reports 
gantt
    title reports - request duration [CI 0.99] : candidate=None, baseline=None
    dateFormat X
    axisFormat %s
section baseline
noprobe (284.862 µs) : 262, 308
.   : milestone, 285,
basic (303.312 µs) : 295, 311
.   : milestone, 303,
loop (12.029 ms) : 11988, 12070
.   : milestone, 12029,
section candidate
noprobe (301.028 µs) : 256, 346
.   : milestone, 301,
basic (298.133 µs) : 288, 308
.   : milestone, 298,
loop (11.365 ms) : 11319, 11410
.   : milestone, 11365,
Loading
  • baseline results
Scenario Request median duration [CI 0.99]
noprobe 284.862 µs [261.781 µs, 307.943 µs]
basic 303.312 µs [295.278 µs, 311.346 µs]
loop 12.029 ms [11.988 ms, 12.07 ms]
  • candidate results
Scenario Request median duration [CI 0.99]
noprobe 301.028 µs [255.634 µs, 346.423 µs]
basic 298.133 µs [287.955 µs, 308.312 µs]
loop 11.365 ms [11.319 ms, 11.41 ms]

@pr-commenter
Copy link

pr-commenter bot commented Jul 9, 2024 •
edited
Loading

Benchmarks

Startup

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master ojung/DEBUG-2504-fix-service-version-sanitize-tags
git_commit_date 1720513897 1720514320
git_commit_sha 9e7aa67 b50a8e3
release_version 1.38.0-SNAPSHOT~9e7aa67ce6 1.38.0-SNAPSHOT~b50a8e3018
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720516683 1720516683
ci_job_id 566184356 566184356
ci_pipeline_id 38675192 38675192
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
module Agent Agent
parent None None
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 54 metrics, 9 unstable metrics.

Startup time reports for insecure-bank 
gantt
    title insecure-bank - global startup overhead: candidate=1.38.0-SNAPSHOT~b50a8e3018, baseline=1.38.0-SNAPSHOT~9e7aa67ce6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.071 s) : 0, 1071254
Total [baseline] (8.53 s) : 0, 8530465
Agent [candidate] (1.063 s) : 0, 1063477
Total [candidate] (8.493 s) : 0, 8493085
section iast
Agent [baseline] (1.174 s) : 0, 1173873
Total [baseline] (8.957 s) : 0, 8956652
Agent [candidate] (1.175 s) : 0, 1175345
Total [candidate] (8.985 s) : 0, 8984593
section iast_HARDCODED_SECRET_DISABLED
Agent [baseline] (1.184 s) : 0, 1184064
Total [baseline] (8.975 s) : 0, 8975450
Agent [candidate] (1.177 s) : 0, 1176564
Total [candidate] (8.934 s) : 0, 8933897
section iast_TELEMETRY_OFF
Agent [baseline] (1.17 s) : 0, 1170257
Total [baseline] (8.97 s) : 0, 8970090
Agent [candidate] (1.181 s) : 0, 1180655
Total [candidate] (8.988 s) : 0, 8988269
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.071 s -
Agent iast 1.174 s 102.619 ms (9.6%)
Agent iast_HARDCODED_SECRET_DISABLED 1.184 s 112.81 ms (10.5%)
Agent iast_TELEMETRY_OFF 1.17 s 99.003 ms (9.2%)
Total tracing 8.53 s -
Total iast 8.957 s 426.187 ms (5.0%)
Total iast_HARDCODED_SECRET_DISABLED 8.975 s 444.985 ms (5.2%)
Total iast_TELEMETRY_OFF 8.97 s 439.625 ms (5.2%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.063 s -
Agent iast 1.175 s 111.868 ms (10.5%)
Agent iast_HARDCODED_SECRET_DISABLED 1.177 s 113.087 ms (10.6%)
Agent iast_TELEMETRY_OFF 1.181 s 117.178 ms (11.0%)
Total tracing 8.493 s -
Total iast 8.985 s 491.508 ms (5.8%)
Total iast_HARDCODED_SECRET_DISABLED 8.934 s 440.812 ms (5.2%)
Total iast_TELEMETRY_OFF 8.988 s 495.184 ms (5.8%) 
gantt
    title insecure-bank - break down per module: candidate=1.38.0-SNAPSHOT~b50a8e3018, baseline=1.38.0-SNAPSHOT~9e7aa67ce6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (671.095 ms) : 0, 671095
BytebuddyAgent [candidate] (665.806 ms) : 0, 665806
GlobalTracer [baseline] (306.796 ms) : 0, 306796
GlobalTracer [candidate] (305.156 ms) : 0, 305156
AppSec [baseline] (50.229 ms) : 0, 50229
AppSec [candidate] (49.708 ms) : 0, 49708
Remote Config [baseline] (680.209 µs) : 0, 680
Remote Config [candidate] (675.869 µs) : 0, 676
Telemetry [baseline] (7.654 ms) : 0, 7654
Telemetry [candidate] (7.645 ms) : 0, 7645
section iast
BytebuddyAgent [baseline] (781.372 ms) : 0, 781372
BytebuddyAgent [candidate] (781.519 ms) : 0, 781519
GlobalTracer [baseline] (295.897 ms) : 0, 295897
GlobalTracer [candidate] (296.207 ms) : 0, 296207
AppSec [baseline] (48.918 ms) : 0, 48918
AppSec [candidate] (50.598 ms) : 0, 50598
IAST [baseline] (26.61 ms) : 0, 26610
IAST [candidate] (25.82 ms) : 0, 25820
Remote Config [baseline] (580.351 µs) : 0, 580
Remote Config [candidate] (584.196 µs) : 0, 584
Telemetry [baseline] (7.022 ms) : 0, 7022
Telemetry [candidate] (7.094 ms) : 0, 7094
section iast_HARDCODED_SECRET_DISABLED
BytebuddyAgent [baseline] (788.099 ms) : 0, 788099
BytebuddyAgent [candidate] (782.52 ms) : 0, 782520
GlobalTracer [baseline] (298.118 ms) : 0, 298118
GlobalTracer [candidate] (297.145 ms) : 0, 297145
AppSec [baseline] (47.671 ms) : 0, 47671
AppSec [candidate] (47.471 ms) : 0, 47471
IAST [baseline] (28.827 ms) : 0, 28827
IAST [candidate] (28.34 ms) : 0, 28340
Remote Config [baseline] (587.278 µs) : 0, 587
Remote Config [candidate] (556.841 µs) : 0, 557
Telemetry [baseline] (7.087 ms) : 0, 7087
Telemetry [candidate] (6.884 ms) : 0, 6884
section iast_TELEMETRY_OFF
BytebuddyAgent [baseline] (778.479 ms) : 0, 778479
BytebuddyAgent [candidate] (786.581 ms) : 0, 786581
GlobalTracer [baseline] (295.561 ms) : 0, 295561
GlobalTracer [candidate] (298.081 ms) : 0, 298081
AppSec [baseline] (47.255 ms) : 0, 47255
AppSec [candidate] (47.731 ms) : 0, 47731
IAST [baseline] (27.969 ms) : 0, 27969
IAST [candidate] (27.055 ms) : 0, 27055
Remote Config [baseline] (611.067 µs) : 0, 611
Remote Config [candidate] (599.955 µs) : 0, 600
Telemetry [baseline] (6.841 ms) : 0, 6841
Telemetry [candidate] (6.951 ms) : 0, 6951
Loading
Startup time reports for petclinic 
gantt
    title petclinic - global startup overhead: candidate=1.38.0-SNAPSHOT~b50a8e3018, baseline=1.38.0-SNAPSHOT~9e7aa67ce6

    dateFormat X
    axisFormat %s
section tracing
Agent [baseline] (1.067 s) : 0, 1066533
Total [baseline] (10.446 s) : 0, 10445903
Agent [candidate] (1.068 s) : 0, 1067576
Total [candidate] (10.308 s) : 0, 10307526
section appsec
Agent [baseline] (1.186 s) : 0, 1185767
Total [baseline] (10.502 s) : 0, 10502169
Agent [candidate] (1.189 s) : 0, 1189228
Total [candidate] (10.476 s) : 0, 10475981
section iast
Agent [baseline] (1.173 s) : 0, 1172935
Total [baseline] (10.729 s) : 0, 10729295
Agent [candidate] (1.184 s) : 0, 1183829
Total [candidate] (10.718 s) : 0, 10717773
section profiling
Agent [baseline] (1.271 s) : 0, 1271201
Total [baseline] (10.635 s) : 0, 10635132
Agent [candidate] (1.277 s) : 0, 1277110
Total [candidate] (10.591 s) : 0, 10590995
Loading
  • baseline results
Module Variant Duration Δ tracing
Agent tracing 1.067 s -
Agent appsec 1.186 s 119.234 ms (11.2%)
Agent iast 1.173 s 106.402 ms (10.0%)
Agent profiling 1.271 s 204.667 ms (19.2%)
Total tracing 10.446 s -
Total appsec 10.502 s 56.266 ms (0.5%)
Total iast 10.729 s 283.392 ms (2.7%)
Total profiling 10.635 s 189.229 ms (1.8%)
  • candidate results
Module Variant Duration Δ tracing
Agent tracing 1.068 s -
Agent appsec 1.189 s 121.652 ms (11.4%)
Agent iast 1.184 s 116.253 ms (10.9%)
Agent profiling 1.277 s 209.534 ms (19.6%)
Total tracing 10.308 s -
Total appsec 10.476 s 168.455 ms (1.6%)
Total iast 10.718 s 410.247 ms (4.0%)
Total profiling 10.591 s 283.469 ms (2.8%) 
gantt
    title petclinic - break down per module: candidate=1.38.0-SNAPSHOT~b50a8e3018, baseline=1.38.0-SNAPSHOT~9e7aa67ce6

    dateFormat X
    axisFormat %s
section tracing
BytebuddyAgent [baseline] (667.514 ms) : 0, 667514
BytebuddyAgent [candidate] (667.789 ms) : 0, 667789
GlobalTracer [baseline] (305.919 ms) : 0, 305919
GlobalTracer [candidate] (306.642 ms) : 0, 306642
AppSec [baseline] (50.105 ms) : 0, 50105
AppSec [candidate] (50.103 ms) : 0, 50103
Remote Config [baseline] (676.045 µs) : 0, 676
Remote Config [candidate] (672.801 µs) : 0, 673
Telemetry [baseline] (7.655 ms) : 0, 7655
Telemetry [candidate] (7.636 ms) : 0, 7636
section appsec
BytebuddyAgent [baseline] (677.615 ms) : 0, 677615
BytebuddyAgent [candidate] (679.844 ms) : 0, 679844
GlobalTracer [baseline] (298.786 ms) : 0, 298786
GlobalTracer [candidate] (300.156 ms) : 0, 300156
AppSec [baseline] (154.362 ms) : 0, 154362
AppSec [candidate] (154.119 ms) : 0, 154119
IAST [baseline] (22.159 ms) : 0, 22159
IAST [candidate] (22.101 ms) : 0, 22101
Remote Config [baseline] (617.673 µs) : 0, 618
Remote Config [candidate] (624.869 µs) : 0, 625
Telemetry [baseline] (8.588 ms) : 0, 8588
Telemetry [candidate] (8.629 ms) : 0, 8629
section iast
BytebuddyAgent [baseline] (780.851 ms) : 0, 780851
BytebuddyAgent [candidate] (788.204 ms) : 0, 788204
GlobalTracer [baseline] (295.637 ms) : 0, 295637
GlobalTracer [candidate] (298.405 ms) : 0, 298405
AppSec [baseline] (47.313 ms) : 0, 47313
AppSec [candidate] (47.6 ms) : 0, 47600
IAST [baseline] (28.012 ms) : 0, 28012
IAST [candidate] (27.734 ms) : 0, 27734
Remote Config [baseline] (589.273 µs) : 0, 589
Remote Config [candidate] (563.505 µs) : 0, 564
Telemetry [baseline] (6.998 ms) : 0, 6998
Telemetry [candidate] (7.655 ms) : 0, 7655
section profiling
BytebuddyAgent [baseline] (665.236 ms) : 0, 665236
BytebuddyAgent [candidate] (670.529 ms) : 0, 670529
GlobalTracer [baseline] (391.606 ms) : 0, 391606
GlobalTracer [candidate] (392.768 ms) : 0, 392768
AppSec [baseline] (52.03 ms) : 0, 52030
AppSec [candidate] (51.922 ms) : 0, 51922
Remote Config [baseline] (655.638 µs) : 0, 656
Remote Config [candidate] (647.499 µs) : 0, 647
Telemetry [baseline] (7.399 ms) : 0, 7399
Telemetry [candidate] (7.403 ms) : 0, 7403
ProfilingAgent [baseline] (97.015 ms) : 0, 97015
ProfilingAgent [candidate] (96.134 ms) : 0, 96134
Profiling [baseline] (97.04 ms) : 0, 97040
Profiling [candidate] (96.158 ms) : 0, 96158
Loading

Load

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
end_time 2024-07-09T08:48:55 2024-07-09T08:55:42
git_branch master ojung/DEBUG-2504-fix-service-version-sanitize-tags
git_commit_date 1720513897 1720514320
git_commit_sha 9e7aa67 b50a8e3
release_version 1.38.0-SNAPSHOT~9e7aa67ce6 1.38.0-SNAPSHOT~b50a8e3018
start_time 2024-07-09T08:48:41 2024-07-09T08:55:29
See matching parameters
Baseline Candidate
application insecure-bank insecure-bank
ci_job_date 1720515685 1720515685
ci_job_id 566184357 566184357
ci_pipeline_id 38675192 38675192
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant iast iast

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 11 metrics, 17 unstable metrics.

Request duration reports for petclinic 
gantt
    title petclinic - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~b50a8e3018, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.334 ms) : 1315, 1353
.   : milestone, 1334,
appsec (1.705 ms) : 1681, 1729
.   : milestone, 1705,
appsec_no_iast (1.717 ms) : 1693, 1740
.   : milestone, 1717,
iast (1.468 ms) : 1446, 1491
.   : milestone, 1468,
profiling (1.473 ms) : 1448, 1497
.   : milestone, 1473,
tracing (1.475 ms) : 1452, 1499
.   : milestone, 1475,
section candidate
no_agent (1.343 ms) : 1323, 1362
.   : milestone, 1343,
appsec (1.699 ms) : 1676, 1723
.   : milestone, 1699,
appsec_no_iast (1.707 ms) : 1683, 1731
.   : milestone, 1707,
iast (1.475 ms) : 1452, 1498
.   : milestone, 1475,
profiling (1.477 ms) : 1452, 1502
.   : milestone, 1477,
tracing (1.468 ms) : 1443, 1492
.   : milestone, 1468,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.334 ms [1.315 ms, 1.353 ms] -
appsec 1.705 ms [1.681 ms, 1.729 ms] 371.363 µs (27.8%)
appsec_no_iast 1.717 ms [1.693 ms, 1.74 ms] 383.044 µs (28.7%)
iast 1.468 ms [1.446 ms, 1.491 ms] 134.894 µs (10.1%)
profiling 1.473 ms [1.448 ms, 1.497 ms] 139.02 µs (10.4%)
tracing 1.475 ms [1.452 ms, 1.499 ms] 141.894 µs (10.6%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 1.343 ms [1.323 ms, 1.362 ms] -
appsec 1.699 ms [1.676 ms, 1.723 ms] 356.571 µs (26.6%)
appsec_no_iast 1.707 ms [1.683 ms, 1.731 ms] 363.786 µs (27.1%)
iast 1.475 ms [1.452 ms, 1.498 ms] 132.364 µs (9.9%)
profiling 1.477 ms [1.452 ms, 1.502 ms] 134.208 µs (10.0%)
tracing 1.468 ms [1.443 ms, 1.492 ms] 124.701 µs (9.3%)
Request duration reports for insecure-bank 
gantt
    title insecure-bank - request duration [CI 0.99] : candidate=1.38.0-SNAPSHOT~b50a8e3018, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
    dateFormat X
    axisFormat %s
section baseline
no_agent (364.031 µs) : 345, 383
.   : milestone, 364,
iast (487.317 µs) : 466, 508
.   : milestone, 487,
iast_FULL (550.43 µs) : 529, 572
.   : milestone, 550,
iast_GLOBAL (508.801 µs) : 487, 531
.   : milestone, 509,
iast_HARDCODED_SECRET_DISABLED (472.669 µs) : 452, 494
.   : milestone, 473,
iast_INACTIVE (453.524 µs) : 431, 476
.   : milestone, 454,
iast_TELEMETRY_OFF (466.276 µs) : 445, 487
.   : milestone, 466,
tracing (445.463 µs) : 424, 467
.   : milestone, 445,
section candidate
no_agent (366.217 µs) : 346, 386
.   : milestone, 366,
iast (482.68 µs) : 461, 504
.   : milestone, 483,
iast_FULL (551.61 µs) : 530, 573
.   : milestone, 552,
iast_GLOBAL (509.572 µs) : 487, 533
.   : milestone, 510,
iast_HARDCODED_SECRET_DISABLED (474.256 µs) : 453, 495
.   : milestone, 474,
iast_INACTIVE (451.261 µs) : 430, 473
.   : milestone, 451,
iast_TELEMETRY_OFF (467.681 µs) : 447, 489
.   : milestone, 468,
tracing (441.559 µs) : 421, 463
.   : milestone, 442,
Loading
  • baseline results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 364.031 µs [344.691 µs, 383.372 µs] -
iast 487.317 µs [466.292 µs, 508.343 µs] 123.286 µs (33.9%)
iast_FULL 550.43 µs [529.285 µs, 571.576 µs] 186.399 µs (51.2%)
iast_GLOBAL 508.801 µs [486.71 µs, 530.892 µs] 144.77 µs (39.8%)
iast_HARDCODED_SECRET_DISABLED 472.669 µs [451.81 µs, 493.528 µs] 108.638 µs (29.8%)
iast_INACTIVE 453.524 µs [431.395 µs, 475.653 µs] 89.493 µs (24.6%)
iast_TELEMETRY_OFF 466.276 µs [445.187 µs, 487.364 µs] 102.245 µs (28.1%)
tracing 445.463 µs [424.143 µs, 466.784 µs] 81.432 µs (22.4%)
  • candidate results
Variant Request duration [CI 0.99] Δ no_agent
no_agent 366.217 µs [346.014 µs, 386.419 µs] -
iast 482.68 µs [461.389 µs, 503.97 µs] 116.463 µs (31.8%)
iast_FULL 551.61 µs [530.191 µs, 573.029 µs] 185.393 µs (50.6%)
iast_GLOBAL 509.572 µs [486.6 µs, 532.544 µs] 143.355 µs (39.1%)
iast_HARDCODED_SECRET_DISABLED 474.256 µs [453.166 µs, 495.346 µs] 108.04 µs (29.5%)
iast_INACTIVE 451.261 µs [429.901 µs, 472.621 µs] 85.044 µs (23.2%)
iast_TELEMETRY_OFF 467.681 µs [446.652 µs, 488.71 µs] 101.465 µs (27.7%)
tracing 441.559 µs [420.501 µs, 462.618 µs] 75.343 µs (20.6%)

Dacapo

Parameters

Baseline Candidate
baseline_or_candidate baseline candidate
git_branch master ojung/DEBUG-2504-fix-service-version-sanitize-tags
git_commit_date 1720513897 1720514320
git_commit_sha 9e7aa67 b50a8e3
release_version 1.38.0-SNAPSHOT~9e7aa67ce6 1.38.0-SNAPSHOT~b50a8e3018
See matching parameters
Baseline Candidate
application biojava biojava
ci_job_date 1720516349 1720516349
ci_job_id 566184358 566184358
ci_pipeline_id 38675192 38675192
cpu_model Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz Intel(R) Xeon(R) Platinum 8259CL CPU @ 2.50GHz
variant appsec appsec

Summary

Found 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics.

Execution time for biojava 
gantt
    title biojava - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~b50a8e3018, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
    dateFormat X
    axisFormat %s
section baseline
no_agent (15.25 s) : 15250000, 15250000
.   : milestone, 15250000,
appsec (15.024 s) : 15024000, 15024000
.   : milestone, 15024000,
iast (19.084 s) : 19084000, 19084000
.   : milestone, 19084000,
iast_GLOBAL (17.87 s) : 17870000, 17870000
.   : milestone, 17870000,
profiling (15.831 s) : 15831000, 15831000
.   : milestone, 15831000,
tracing (15.239 s) : 15239000, 15239000
.   : milestone, 15239000,
section candidate
no_agent (15.464 s) : 15464000, 15464000
.   : milestone, 15464000,
appsec (14.922 s) : 14922000, 14922000
.   : milestone, 14922000,
iast (18.722 s) : 18722000, 18722000
.   : milestone, 18722000,
iast_GLOBAL (17.752 s) : 17752000, 17752000
.   : milestone, 17752000,
profiling (14.928 s) : 14928000, 14928000
.   : milestone, 14928000,
tracing (14.953 s) : 14953000, 14953000
.   : milestone, 14953000,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.25 s [15.25 s, 15.25 s] -
appsec 15.024 s [15.024 s, 15.024 s] -226.0 ms (-1.5%)
iast 19.084 s [19.084 s, 19.084 s] 3.834 s (25.1%)
iast_GLOBAL 17.87 s [17.87 s, 17.87 s] 2.62 s (17.2%)
profiling 15.831 s [15.831 s, 15.831 s] 581.0 ms (3.8%)
tracing 15.239 s [15.239 s, 15.239 s] -11.0 ms (-0.1%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 15.464 s [15.464 s, 15.464 s] -
appsec 14.922 s [14.922 s, 14.922 s] -542.0 ms (-3.5%)
iast 18.722 s [18.722 s, 18.722 s] 3.258 s (21.1%)
iast_GLOBAL 17.752 s [17.752 s, 17.752 s] 2.288 s (14.8%)
profiling 14.928 s [14.928 s, 14.928 s] -536.0 ms (-3.5%)
tracing 14.953 s [14.953 s, 14.953 s] -511.0 ms (-3.3%)
Execution time for tomcat 
gantt
    title tomcat - execution time [CI 0.99] : candidate=1.38.0-SNAPSHOT~b50a8e3018, baseline=1.38.0-SNAPSHOT~9e7aa67ce6
    dateFormat X
    axisFormat %s
section baseline
no_agent (1.464 ms) : 1453, 1476
.   : milestone, 1464,
appsec (2.23 ms) : 2195, 2265
.   : milestone, 2230,
iast (1.979 ms) : 1938, 2021
.   : milestone, 1979,
iast_GLOBAL (2.016 ms) : 1974, 2059
.   : milestone, 2016,
profiling (1.863 ms) : 1830, 1897
.   : milestone, 1863,
tracing (1.838 ms) : 1805, 1870
.   : milestone, 1838,
section candidate
no_agent (1.466 ms) : 1454, 1477
.   : milestone, 1466,
appsec (2.249 ms) : 2213, 2285
.   : milestone, 2249,
iast (1.977 ms) : 1936, 2019
.   : milestone, 1977,
iast_GLOBAL (2.018 ms) : 1977, 2059
.   : milestone, 2018,
profiling (1.854 ms) : 1819, 1889
.   : milestone, 1854,
tracing (1.853 ms) : 1820, 1886
.   : milestone, 1853,
Loading
  • baseline results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.464 ms [1.453 ms, 1.476 ms] -
appsec 2.23 ms [2.195 ms, 2.265 ms] 766.035 µs (52.3%)
iast 1.979 ms [1.938 ms, 2.021 ms] 515.109 µs (35.2%)
iast_GLOBAL 2.016 ms [1.974 ms, 2.059 ms] 552.262 µs (37.7%)
profiling 1.863 ms [1.83 ms, 1.897 ms] 399.219 µs (27.3%)
tracing 1.838 ms [1.805 ms, 1.87 ms] 373.626 µs (25.5%)
  • candidate results
Variant Execution Time [CI 0.99] Δ no_agent
no_agent 1.466 ms [1.454 ms, 1.477 ms] -
appsec 2.249 ms [2.213 ms, 2.285 ms] 783.175 µs (53.4%)
iast 1.977 ms [1.936 ms, 2.019 ms] 511.739 µs (34.9%)
iast_GLOBAL 2.018 ms [1.977 ms, 2.059 ms] 552.095 µs (37.7%)
profiling 1.854 ms [1.819 ms, 1.889 ms] 388.192 µs (26.5%)
tracing 1.853 ms [1.82 ms, 1.886 ms] 387.344 µs (26.4%)

@ojung ojung force-pushed the ojung/DEBUG-2504-fix-service-version-sanitize-tags branch from 702619d to b50a8e3 Compare July 9, 2024 08:38
@ojung ojung merged commit 8629967 into master Jul 9, 2024
83 checks passed
@ojung ojung deleted the ojung/DEBUG-2504-fix-service-version-sanitize-tags branch July 9, 2024 14:44
@github-actions github-actions bot added this to the 1.38.0 milestone Jul 9, 2024
@nayeem-kamal nayeem-kamal changed the title Fix service version sanitize tags Fix service version and sanitize tags Aug 5, 2024
@nayeem-kamal nayeem-kamal added the comp: debugger Dynamic Instrumentation label Aug 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpbempel jpbempel jpbempel approved these changes

Assignees
No one assigned
Labels
comp: debugger Dynamic Instrumentation
Projects
None yet
Milestone
1.38.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ojung @jpbempel @nayeem-kamal