fix: Propagate otel span kind to span.kind tag
#6638
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since opentelemetry tags always have span kinds defined (and if the host project doesn't specify it then it defaults to INTERNAL) then let's propagate that span kind to DD's `span.kind` tag so that it is properly visible in the UI. Otherwise we are forcing clients to add a redundant addAttribute if they want to retain the span kind after the trace is sent to datadog.
|
I don't think I can add a label myself, but I guess this should be a semver-patch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Propagates opentelemetry's span kind into datadog's
span.kindtag.Motivation
Since opentelemetry tags always have span kinds defined (and if the host project doesn't specify it then it defaults to INTERNAL) then let's propagate that span kind to DD's
span.kindtag so that it is properly visible in the UI. Otherwise we are forcing clients to add a redundant addAttribute if they want to retain the span kind after the trace is sent to datadog.