Skip to content

fix: Propagate otel span kind to span.kind tag #6638

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Propagate otel span kind to span.kind tag #6638

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions packages/dd-trace/src/opentelemetry/span.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ const { timeInputToHrTime } = require('@opentelemetry/core')
const tracer = require('../../')
const DatadogSpan = require('../opentracing/span')
const { ERROR_MESSAGE, ERROR_TYPE, ERROR_STACK, IGNORE_OTEL_ERROR } = require('../constants')
const { SERVICE_NAME, RESOURCE_NAME } = require('../../../../ext/tags')
const { SERVICE_NAME, RESOURCE_NAME, SPAN_KIND } = require('../../../../ext/tags')
const kinds = require('../../../../ext/kinds')

const SpanContext = require('./span_context')
Expand Down Expand Up @@ -146,7 +146,8 @@ class Span {
integrationName: parentTracer?._isOtelLibrary ? 'otel.library' : 'otel',
tags: {
[SERVICE_NAME]: _tracer._service,
[RESOURCE_NAME]: spanName
[RESOURCE_NAME]: spanName,
[SPAN_KIND]: spanKindNames[kind]
},
links
}, _tracer._debug)
Expand Down
9 changes: 8 additions & 1 deletion packages/dd-trace/test/opentelemetry/span.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const SpanContext = require('../../src/opentelemetry/span_context')
const { NoopSpanProcessor } = require('../../src/opentelemetry/span_processor')

const { ERROR_MESSAGE, ERROR_STACK, ERROR_TYPE, IGNORE_OTEL_ERROR } = require('../../src/constants')
const { SERVICE_NAME, RESOURCE_NAME } = require('../../../../ext/tags')
const { SERVICE_NAME, RESOURCE_NAME, SPAN_KIND } = require('../../../../ext/tags')
const kinds = require('../../../../ext/kinds')
const format = require('../../src/format')

Expand Down Expand Up @@ -235,6 +235,13 @@ describe('OTel Span', () => {
expect(context._tags[RESOURCE_NAME]).to.equal('name')
})

it('should copy span kind to span.kind', () => {
const span = makeSpan('name', { kind: api.SpanKind.CONSUMER })

const context = span._ddSpan.context()
expect(context._tags[SPAN_KIND]).to.equal(kinds.CONSUMER)
})

it('should expose span context', () => {
const span = makeSpan('name')

Expand Down
Loading