Skip to content

chore: add setup version gates#17948

Open
P403n1x87 wants to merge 2 commits intomainfrom
chore/setup-version-gates
Open

chore: add setup version gates#17948
P403n1x87 wants to merge 2 commits intomainfrom
chore/setup-version-gates

Conversation

@P403n1x87
Copy link
Copy Markdown
Contributor

Description

We add version gates to the setup script to prevent parts that cannot be compiled with a new version of CPython to compile. This allows the build process to succeed while the various native components introduce support for the new version.

We add version gates to the setup script to prevent parts that cannot be
compiled with a new version of CPython to compile. This allows the build
process to succeed while the various native components introduce support
for the new version.
@P403n1x87 P403n1x87 added the changelog/no-changelog A changelog entry is not required for this PR. label May 7, 2026
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Codeowners resolved as

setup.py                                                                @DataDog/python-guild

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 7, 2026

Benchmarks

Benchmark execution time: 2026-05-08 11:17:02

Comparing candidate commit 9bec4df in PR branch chore/setup-version-gates with baseline commit d1a7113 in branch main.

Found 0 performance improvements and 5 performance regressions! Performance is the same for 591 metrics, 4 unstable metrics.

scenario:iast_aspects-re_expand_aspect

  • 🟥 execution_time [+255.243µs; +299.403µs] or [+7.332%; +8.601%]

scenario:iastaspects-lower_noaspect

  • 🟥 execution_time [+19.139µs; +23.896µs] or [+8.192%; +10.228%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+91.883µs; +101.458µs] or [+21.600%; +23.850%]

scenario:span-start

  • 🟥 execution_time [+1.190ms; +1.368ms] or [+7.620%; +8.761%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+213.100ns; +248.238ns] or [+10.276%; +11.971%]

Copy link
Copy Markdown
Contributor

@vlad-scherbich vlad-scherbich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but are those failing tests related?

@P403n1x87 P403n1x87 marked this pull request as ready for review May 8, 2026 13:08
@P403n1x87 P403n1x87 requested a review from a team as a code owner May 8, 2026 13:08
@P403n1x87 P403n1x87 requested a review from florentinl May 8, 2026 13:08
Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9bec4df353

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread setup.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants