Skip to content

chore: add setup version gates #17948

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
P403n1x87 wants to merge 2 commits into
base: main
Choose a base branch
from
+28 −23
Open

chore: add setup version gates #17948

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f0ad30
chore: add setup version gates
P403n1x87 May 7, 2026
9bec4df
Merge branch 'main' into chore/setup-version-gates
P403n1x87 May 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 28 additions & 23 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ def is_64_bit_python():


rust_features = ["stats"]
if CURRENT_OS in ("Linux", "Darwin") and is_64_bit_python():
if CURRENT_OS in ("Linux", "Darwin") and is_64_bit_python() and sys.version_info < (3, 15):
rust_features.append("profiling")
if not SERVERLESS_BUILD:
rust_features.append("crashtracker")
Expand Down Expand Up @@ -842,7 +842,7 @@ def run(self):
self.build_rust()

# Build libdd_wrapper before building other extensions that depend on it
if CURRENT_OS in ("Linux", "Darwin") and is_64_bit_python():
if CURRENT_OS in ("Linux", "Darwin") and is_64_bit_python() and sys.version_info < (3, 15):
with _time_phase("build_libdd_wrapper"):
self.build_libdd_wrapper()

Expand Down Expand Up @@ -1606,7 +1606,7 @@ def get_exts_for(name):
CMakeExtension("ddtrace.appsec._iast._taint_tracking._native", source_dir=IAST_DIR, optional=False)
)

if CURRENT_OS in ("Linux", "Darwin") and is_64_bit_python():
if CURRENT_OS in ("Linux", "Darwin") and is_64_bit_python() and sys.version_info < (3, 15):
# Memory profiler now uses CMake to support Abseil dependency
MEMALLOC_DIR = HERE / "ddtrace" / "profiling" / "collector"
memalloc_cmake_args = []
Expand Down Expand Up @@ -1653,25 +1653,28 @@ def get_exts_for(name):
cython_exts = []
if os.getenv("DD_CYTHONIZE", "1").lower() in ("1", "yes", "on", "true"):
with _time_phase("cythonize"):
cython_exts = cythonize(
[
Cython.Distutils.Extension(
"ddtrace.internal._tagset",
sources=["ddtrace/internal/_tagset.pyx"],
language="c",
),
Extension(
"ddtrace.internal._encoding",
["ddtrace/internal/_encoding.pyx"],
include_dirs=["."],
libraries=encoding_libraries,
define_macros=[(f"__{sys.byteorder.upper()}_ENDIAN__", "1")],
),
Extension(
"ddtrace.internal.telemetry.metrics_namespaces",
["ddtrace/internal/telemetry/metrics_namespaces.pyx"],
language="c",
),
_cython_sources = [
Cython.Distutils.Extension(
"ddtrace.internal._tagset",
sources=["ddtrace/internal/_tagset.pyx"],
language="c",
),
Extension(
"ddtrace.internal._encoding",
["ddtrace/internal/_encoding.pyx"],
include_dirs=["."],
libraries=encoding_libraries,
define_macros=[(f"__{sys.byteorder.upper()}_ENDIAN__", "1")],
),
Extension(
"ddtrace.internal.telemetry.metrics_namespaces",
["ddtrace/internal/telemetry/metrics_namespaces.pyx"],
language="c",
),
]

if sys.version_info < (3, 15):
_cython_sources += [
Cython.Distutils.Extension(
Comment thread
P403n1x87 marked this conversation as resolved.
"ddtrace.profiling._threading",
sources=["ddtrace/profiling/_threading.pyx"],
Expand Down Expand Up @@ -1702,7 +1705,9 @@ def get_exts_for(name):
sources=["ddtrace/profiling/collector/_lock.pyx"],
language="c",
),
],
]
cython_exts = cythonize(
_cython_sources,
compile_time_env={
"PY_MAJOR_VERSION": sys.version_info.major,
"PY_MINOR_VERSION": sys.version_info.minor,
Expand Down
Loading