chore: runtime version string in ddtrace_serverless#17964
Conversation
…h at runtime (ddtrace_serverless)
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 42e4286199
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Codeowners resolved as |
Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
emmettbutler
added
the
changelog/no-changelog
emmettbutler
changed the title
emmettbutler
added
changelog/no-changelog
BenchmarksBenchmark execution time: 2026-05-12 14:18:22 Comparing candidate commit 8d1ec22 in PR branch Found 0 performance improvements and 3 performance regressions! Performance is the same for 563 metrics, 4 unstable metrics. scenario:iastaspectsospath-ospathbasename_aspect
scenario:span-start
scenario:telemetryaddmetric-1-count-metric-1-times
|
|
/merge |
|
View all feedbacks in Devflow UI.
This PR is rejected because it was updated |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
devflow unqueued this merge request: It did not become mergeable within the expected time |
🎉 All green!❄️ No new flaky tests detected 🔗 Commit SHA: 8d1ec22 | Docs | Datadog PR Page | Give us feedback! |
|
/merge |
|
View all feedbacks in Devflow UI.
PR already in the queue with status waiting |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'main' is 120 minutes. |
|
/merge |
|
View all feedbacks in Devflow UI.
The expected merge time in
error while getting head build completion result DetailsError: There was an error while retrieving the result for pipeline 112277682 FullStacktrace: |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
error while getting head build completion result DetailsError: There was an error while retrieving the result for pipeline 112541355 FullStacktrace: |
|
/merge |
|
View all feedbacks in Devflow UI.
This pull request is not mergeable according to GitHub. Common reasons include pending required checks, missing approvals, or merge conflicts — but it could also be blocked by other repository rules or settings.
The expected merge time in
The merge request has been interrupted because the build 0 took longer than expected. The current limit for the base branch 'main' is 120 minutes. |
## Description This PR: #17964 broke main because it introduced code that is incompatible with python3.9. However, microbenchmarks are running on python3.9 which broke http microbenchmarks. This PR fixes the issue Co-authored-by: louis.tricot <louis.tricot@datadoghq.com>
This change handles the fact that `__package__` and `importlib.metadata.version(__package__)` don't always match at runtime, specifically in the ddtrace_serverless wheel. --------- Co-authored-by: Brett Langdon <brett.langdon@datadoghq.com>
## Description This PR: #17964 broke main because it introduced code that is incompatible with python3.9. However, microbenchmarks are running on python3.9 which broke http microbenchmarks. This PR fixes the issue Co-authored-by: louis.tricot <louis.tricot@datadoghq.com>
2 participants
This change handles the fact that
__package__andimportlib.metadata.version(__package__)don't always match at runtime, specifically in the ddtrace_serverless wheel.