POLAR@3: Support for bundled default plugin icons #408
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Plugin icons can be configured via client. However, a sensible default is nice-to-have. In addition, default icons are also auto-bundled and do not need to be provided by the user.
oeninghe-dataport
requested review from
dopenguin and
warm-coolguy
as code owners
oeninghe-dataport
added
bug
oeninghe-dataport
force-pushed
the
fix/bundle-default-extra-icons
branch
from
13dd8e5 to
2e0bb89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Plugins can have default icons.
This has a major advantage:
Icons named in the main code (not examples) are automatically bundled.
Instructions for local reproduction and review
Test using
npm run preview.You can see the layerChooser icon is visible.
Relevant tickets, issues, et cetera
Closes #396 and solves #397 partially