Feat/new layout #12966
+15
−2
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There was a problem hiding this comment. I am bit confused why this was counted as tvl in the first place, but changing folder names breaks our server There was a problem hiding this comment. We want to show Total BTC staked to mint stBTC and stBTC supply on BNB. There are two parts. |
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| const { sumTokensExport } = require("../helper/sumTokens"); | ||
| const bitcoinAddressBook = require('../helper/bitcoin-book/index.js') | ||
|
|
||
| module.exports = { | ||
| methodology: "Lorenzo, As the Bitcoin Liquidity Finance Layer", | ||
| doublecounted:true, | ||
| bitcoin: { tvl: sumTokensExport({ owners : bitcoinAddressBook.lorenzo }) } | ||
| }; |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,8 +1,10 @@ | ||
| const { sumTokensExport } = require("../helper/sumTokens"); | ||
| const bitcoinAddressBook = require('../helper/bitcoin-book/index.js') | ||
|
|
||
| // Lorenzo Protocol Tota TVL | ||
| const allBtcAddressList = [...bitcoinAddressBook.lorenzo, ...bitcoinAddressBook.lorenzo2] | ||
|
There was a problem hiding this comment. no, this leads to doublecounting, as we have already listed stbtc & enzoBTC part. This merged listing is redundant imo, we already show a parent protocol that includes all sub protocols There was a problem hiding this comment. Do you change the sub protocol tab to Lorenzo stBTC, Lorenzo stBTC from BNB, Lorenzo enzoBTC? |
||
| module.exports = { | ||
| methodology: "Lorenzo, As the Bitcoin Liquidity Finance Layer", | ||
| doublecounted:true, | ||
| bitcoin: { tvl: sumTokensExport({ owners : allBtcAddressList }) } | ||
| }; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this change is good, thanks