Feat/new layout #12966
Open
Feat/new layout #12966
+15
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
0xajing
commented
Jan 4, 2025
•
0xajing
commented
- update lorenzo bitcoin book, add bc1p9ta9m4h6z5hz5mvu2450qqrd5x507a25c4uper8nkxllhs94x7msv77l0s
- new tab layout:
- Lorenzo: Lorenzo Protocol Total, all staked BTC, from stBTC and enzoBTC
- Lorenzo stBTC: all BTC staked to mint stBTC
- Lorenzo enzoBTC: all BTC staked to mint enzoBTC
- Lorenzo stBTC from BNB: stBTC supply on BNB
|
The adapter at projects/lorenzo exports TVL: |
|
The adapter at projects/lorenzo-stbtc exports TVL: |
0xajing
force-pushed
the
feat/new-layout
branch
from
72ebdba to
bd7913a
Compare
|
The adapter at projects/lorenzo exports TVL: |
|
The adapter at projects/lorenzo-stbtc exports TVL: |
|
The adapter at projects/lorenzo exports TVL: |
|
The adapter at projects/lorenzo-stbtc exports TVL: |
g1nt0ki
reviewed
Jan 7, 2025
There was a problem hiding this comment.
I am bit confused why this was counted as tvl in the first place, but changing folder names breaks our server
g1nt0ki
reviewed
Jan 7, 2025
| @@ -1,8 +1,10 @@ | |||
| const { sumTokensExport } = require("../helper/sumTokens"); | |||
| const bitcoinAddressBook = require('../helper/bitcoin-book/index.js') | |||
|
|
|||
| // Lorenzo Protocol Tota TVL | |||
| const allBtcAddressList = [...bitcoinAddressBook.lorenzo, ...bitcoinAddressBook.lorenzo2] | |||
There was a problem hiding this comment.
no, this leads to doublecounting, as we have already listed stbtc & enzoBTC part.
This merged listing is redundant imo, we already show a parent protocol that includes all sub protocols
g1nt0ki
reviewed
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.