Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port psionic sacraficing #1883

Merged
merged 10 commits into from
Oct 2, 2024
Merged

Conversation

deltanedas
Copy link
Member

@deltanedas deltanedas commented Sep 21, 2024

About the PR

no soul crystals yet so its just for borging and lowering glimmer

Why / Balance

you can still trivially psicheck people by strapping them and seeing if the doafter can start. in the future this should have some cost like failing to psicheck with the psionic knife (it shocks you)

Technical details

some changes:

  • you cant psicheck ssd people, changed the order of the checks
  • you cant alt f4 before doafter ends to prevent being sacraficed (hrp server wow)
  • it uses entity tables for loot, bluespace crystals are now in yml instead of hardcoded
  • theres no 10% -> 50% chance for psionic -> chaplain anymore, theres no way for anyone to add BibleUser ingame for someone being promoted. chaplains should be sacraficing as part of their job rp not just because funny 5x gamer loot. the gamer loot should also not be balanced around psionics only getting a 10% chance to roll it

also since golems dont exist snipped that out of the guidebook

Media

altars have an examine now
05:40:53

the temp guidebook until golems are real
05:43:14

after sacraficing brain drops so you can borg it
05:56:44

Requirements

Breaking changes

no

Changelog
🆑

  • add: Psionics can now be sacrificed in the chapel to lower glimmer.

@github-actions github-actions bot added Changes: YML Changes any yml files Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: Documentation Changes any xml or md files labels Sep 21, 2024
@ghost
Copy link

ghost commented Sep 21, 2024

Ermmm, ackshually, it's spelt "sacrifice," not sacrafice 🤓 ☝️

@deltanedas
Copy link
Member Author

ok ranes typo not mine

@deltanedas deltanedas marked this pull request as ready for review September 22, 2024 01:16
@deltanedas deltanedas requested review from a team as code owners September 22, 2024 01:16
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well now I'm going to be annoying about Rane's typo because some of it is possibly admin / mapper facing and some of it is player-facing. Yippee.

Resources/Prototypes/Nyanotrasen/psionicArtifacts.yml Outdated Show resolved Hide resolved
Resources/Locale/en-US/deltav/chapel/altar.ftl Outdated Show resolved Hide resolved
Resources/Locale/en-US/deltav/chapel/altar.ftl Outdated Show resolved Hide resolved
Content.Shared/DeltaV/Chapel/SacraficialAltarComponent.cs Outdated Show resolved Hide resolved
Resources/Prototypes/Nyanotrasen/psionicArtifacts.yml Outdated Show resolved Hide resolved
@Avalon-Proto
Copy link
Contributor

Super curious about how this is gona mix things up, and can't wait to see Traitor chaplains going crazy

MilonPL
MilonPL previously approved these changes Sep 23, 2024
Copy link
Member

@MilonPL MilonPL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code looks good overall, pending approval from direction still

Content.Server/DeltaV/Chapel/SacraficialAltarSystem.cs Outdated Show resolved Hide resolved
MilonPL
MilonPL previously approved these changes Sep 24, 2024
@deltanedas deltanedas requested a review from a team September 24, 2024 08:47
@TadJohnson00
Copy link
Contributor

I'm good with it if you remove the gamerloot

@MilonPL
Copy link
Member

MilonPL commented Sep 24, 2024

I'm good with it if you remove the gamerloot

like all of it?

@deltanedas deltanedas enabled auto-merge (squash) October 2, 2024 13:04
@deltanedas deltanedas dismissed TadJohnson00’s stale review October 2, 2024 13:04

direction fell off

@deltanedas deltanedas merged commit cc6bbfe into DeltaV-Station:master Oct 2, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Documentation Changes any xml or md files Changes: Localization Changes any ftl files Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants