Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

surgery and shitmed tweaks #2721

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Lyndomen
Copy link
Contributor

About the PR

more damage across the board really, tweaked sleep modifiers, less speed modifier for medical professionals.

please test this in a devenv and report how this feels, im not a surgery pro. Very open to feedback

Why / Balance

surgery overtuned especially remove bruise and burn

Technical details

yaml

Media

Requirements

  • I have tested all added content and changes.
  • I have added media to this PR or it does not require an ingame showcase.

Breaking changes

Changelog

@Lyndomen Lyndomen requested a review from a team as a code owner January 14, 2025 02:58
@github-actions github-actions bot added size/S 16-63 lines Changes: YML Changes any yml files S: Needs Review and removed size/S 16-63 lines labels Jan 14, 2025
@@ -22,8 +22,8 @@
- type: SurgeryDamageChangeEffect
damage:
types:
Bloodloss: 10
Slash: 3 # DeltaV
#Bloodloss: 10 # DeltaV
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i dont think this even works right tbh. sleeping and not is weird

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, i did some quick testing and it always applies the 0.5 modification.

Bloodloss: 10
Slash: 3 # DeltaV
#Bloodloss: 10 # DeltaV
Slash: 12 # DeltaV
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

combat meta :trollface:

Copy link
Contributor

@Radezolid Radezolid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TL;DR: DeltaV comment

@@ -45,7 +45,7 @@
- type: SurgeryDamageChangeEffect
damage:
types:
Bloodloss: -5
Bloodloss: -3
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add DeltaV comment.

@@ -66,7 +66,7 @@
- type: SurgeryDamageChangeEffect # DeltaV
damage:
types:
Slash: 2
Slash: 4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeltaV comment

Comment on lines +109 to +112
sleepModifier: 0.25 # Highly invasive, large damage if the patient is wriggling around
damage:
types:
Blunt: 10
Blunt: 15
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeltaV comment on these two changes.

@@ -350,7 +351,7 @@
- type: SurgeryDamageChangeEffect # DeltaV
damage:
types:
Slash: 2
Slash: 4
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeltaV comment

@@ -468,7 +473,7 @@
- type: SurgeryRemoveOrganStep
- type: SurgeryStepEmoteEffect
- type: SurgeryDamageChangeEffect # DeltaV
sleepModifier: 0.1 # Maints organ transplants are BAD
sleepModifier: 0.15 # Maints organ transplants are BAD
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeltaV comment

@@ -27,7 +27,7 @@
- !type:AddComponentSpecial
components:
- type: SurgerySpeedModifier
speedModifier: 1.75
speedModifier: 1.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeltaV comment

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i also think paramed should be lower/removed since parameds job is to triage and get them to med alive for proper treatment by docs/surgeons

@@ -21,7 +21,7 @@
- !type:AddComponentSpecial
components:
- type: SurgerySpeedModifier
speedModifier: 1.75
speedModifier: 1.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeltaV comment

@@ -49,7 +49,7 @@
- !type:AddComponentSpecial
components:
- type: SurgerySpeedModifier
speedModifier: 2.5
speedModifier: 1.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeltaV comment

@@ -20,7 +20,7 @@
- !type:AddComponentSpecial
components:
- type: SurgerySpeedModifier
speedModifier: 1.75
speedModifier: 1.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DeltaV comment

@Lyndomen
Copy link
Contributor Author

Re: why all the speed modifiers are the same. I don't personally like jobs just being instrinsically better than others at certain task. When we start relying on that as a balancing mechanic we have to start pretending getting hired into a job isn't real. I would prefer that the speed of an operation naturally comes from the skill of the character & player, rather than enforced by job

@Lyndomen
Copy link
Contributor Author

It's worth mentioning that this is not direction approved, not everyone agrees that job modifiers bad. Also have to find limb health

@deltanedas
Copy link
Member

i agree, CMO starts with advanced tools anyway so speed modifiers could be axed entirely and CMO would still be the fastest surgeon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: YML Changes any yml files S: Needs Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants