Adds the Justice Department #660
Conversation
github-actions
bot
added
Changes: Localization
|
These .rsi need to be fixed. Check the meta data file for spelling/casing/etc.
|
Ok I believe I fixed those. Still can't get the test environment to open on my end, but I'm not getting errors from those rsi files anymore. |
|
Errors in the console? |
Entire console is errors 😭 |
CrimeAssist, The Crusher and the ConveyorBelt are all throwing these issues |
|
It won't save my comment but the other test error is about Lawyer.png, I think the file name needs to be capitalised? Hope this helps a little |
|
At first look, every single file looks fine, however I think lack of files could be the issue due to a new radio channel being mentioned in the headset for lawyers, I would put them for now in # as a note, on another though, if it were to be a full department then it probably should have a camera system on it aswell which would require you to add in:
(Not sure if there is more but those 2 seem very important from what im seein, one regardin the radio channel and the other with cameras if there are any plans on that aswell, could be a separate PR just so this isnt 10k code) |
oh shit i forgot to add the radio channel |
|
I do not have the spoons to really dive into this at the moment, but I'm getting a slew of fatal errors (such as this one) when I try to run the server on my end. I am thinking it might be because my branch is out of date with master, but I'm not experienced enough to be certain and I don't want to accidentally break anything while trying to fix it.
|
Try running the RUN_THIS.py using cmd or powershell and then restarting visual studio. |
That didn't work |
|
if you think its not up to date, just make this branch:
|
Or instead of spamming notifications into my inbox just go to your fork and use the update button after selecting your branch |
|
Me when the misinput |
Is it wrong of me to seek technical help on Github? Because I find I get more help here than on Discord. Especially since the question was directly related to Git. |
No I'm talking about changing pull request status. Pull requests are here for this sorta stuff, but marking something as ready for review and back to draft every time you want to update stuff just sends me notifications |
Signed-off-by: Timemaster99 <[email protected]>
Signed-off-by: Timemaster99 <[email protected]>
Resolved now. I appreciate you taking the time to check 200 files of changes 👍 |
NullWanderer
added
Priority: 2-High
Resources/Prototypes/DeltaV/Catalog/Fills/Lockers/chiefjustice.yml
Outdated
Show resolved
Hide resolved
Resources/Prototypes/DeltaV/Entities/Structures/Doors/Windoors/windoor.yml
Show resolved
Hide resolved
|
Oh I totally forgot in my review! Does this add any new access types? |
Ah right, it already adds everything in the places it needs to be. False alarm |
|
file comments might be locked but |
Signed-off-by: Timemaster99 <[email protected]>
Fixed |
# Description This ports DeltaV-Station/Delta-v#660 > ## About the PR > Adds the Justice Department, a department enveloping the lawyer and 3 new roles that manage the court system and charges against the accused. Includes: • New department, Justice! • 3 new roles: ◦ Chief Justice: The main, impartial judge for the station responsible for adjudicating criminal and civil trials, as well as other small matters like paroles and pardons. ◦ Clerk: The court clerk, who organizes trials, notarizes court documents (warrants, sentences, etc), and ensures correct sentencing and due process for the accused in sec custody. ◦ Prosecutor: A special lawyer role that legally advises sec and handles all of its court prep and prosecution, freeing up sec's time to go stun baton the clown instead of waiting for trial. • Antag objective to steal the Clerk's notary stamp, an object imbued with the authority to officialize court decisions. • Made the Lawyer role easier to understand and added them to the department. Renamed to Attorney, they now exclusively defend the accused or can sue on their behalf. Can also curse at the prosecutor in the bar. • Changed SoP to match. Notable changes include ◦ Felony charges and above must be reviewed and approved by the Clerk or Chief Justice if those roles are active. ◦ Parole, criminal trials, and civil trials are now all adjudicated by the Chief Justice, or the clerk in their absence. ◦ To ensure fair judgement, a Captain can only remove the Chief Justice with a majority vote from command. ◦ Warrants and court decisions must be written down and stamped with the notary stamp. Warrants must be approved by the Chief Justice. ◦ Full list of SoP changes can be found here: https://docs.google.com/document/d/12ZKTtzvVWBuC7PuiREL9v7mhVZve11p0-T6MBPpVeGs/edit?usp=sharing • Classy wooden desk timer to help keep trials timely and within limits. > > **TO DO:** Chief Justice > > * [x] Role > * [x] Inventory > * [x] Job Description > * [x] Icon > * [x] Access (CMD/CJ/Sec/Justice*) > * [x] Airlocks > * [x] Spawnpoint > * [x] Closet(just reuse legal w/ a lock) > * [x] Gavel** (proto/sprite/sound) > * [x] Stamp (proto/sprite) > * [x] Drip > > Court Clerk > > * [x] Role > * [x] Inventory > * [x] Job Description > * [x] Icon > * [x] Access (Sec/Justice*) > * [x] Spawnpoint > * [x] Closet(just reuse legal w/ a lock) > * [x] Stamp** (proto/sprite) > * [x] Warrant document > * [x] Drip > > Prosecutor > > * [x] Role > * [x] Inventory > * [x] Job Description > * [x] Icon > * [x] Access (Sec/Justice*) > * [x] Spawnpoint > * [x] Closet(just reuse legal w/ a lock) > * [x] Drip(Can be same as lawyer but should have a unique badge) > > SoP/Guidlines > > * [x] Civil and criminal law-penalties > * [x] Legal mutiny? > * [x] Assigning judges when no judge is present > * [x] Judge is representative of CC. Not necessarily _above_ captain but outside. > * [x] When to appeal to a jury? How to pick a jury? (random would be good) > * [x] Rules for gaining warrants > * [x] Procedure for arresting officer filing criminal charges > * [x] Rules for summoning witnesses > * [ ] Guide/book > > Other > > * [ ] Station Beacons > > ## Notes: > * We might want to consider bringing back brig access for cells to give legal dept sec access and not control over prisoners. > * Mapping would need to provide offices for CJ, CC, and Prosecuter. > * Chief Justice is a rep of CC not necessarily above captain but outside > > ## Why / Balance > The current legal system in-game is built around LRP gameplay, with security handling everything relating to arrests, sentencing, trials, and execution. Additionally, it is near-impossible to find an impartial judge for any court case with the current system. New legal department would guarantee an impartial and available judge (whether it be the Chief Justice or Clerk) for any court case, take pressure off of security to handle things like sentencing and trials. Additionally, there will be more roleplay opportunities for things like civil cases, inter-department disputes, internal affairs, or whatever else you may need legal help with. > > ## Technical details > n/a > > ## Media >   > > * [x] I have added screenshots/videos to this PR showcasing its changes in-game, **or** this PR does not require an in-game showcase > > ## Breaking changes > none that I know of 😓 > **Changelog** 🆑 Leo, Velcroboy, and Timemaster - add: Added The Justice Department >:)
About the PR
Adds the Justice Department, a department enveloping the lawyer and 3 new roles that manage the court system and charges against the accused. Includes:
• New department, Justice!
• 3 new roles:
◦ Chief Justice: The main, impartial judge for the station responsible for adjudicating criminal and civil trials, as well as other small matters like paroles and pardons.
◦ Clerk: The court clerk, who organizes trials, notarizes court documents (warrants, sentences, etc), and ensures correct sentencing and due process for the accused in sec custody.
◦ Prosecutor: A special lawyer role that legally advises sec and handles all of its court prep and prosecution, freeing up sec's time to go stun baton the clown instead of waiting for trial.
• Antag objective to steal the Clerk's notary stamp, an object imbued with the authority to officialize court decisions.
• Made the Lawyer role easier to understand and added them to the department. Renamed to Attorney, they now exclusively defend the accused or can sue on their behalf. Can also curse at the prosecutor in the bar.
• Changed SoP to match. Notable changes include
◦ Felony charges and above must be reviewed and approved by the Clerk or Chief Justice if those roles are active.
◦ Parole, criminal trials, and civil trials are now all adjudicated by the Chief Justice, or the clerk in their absence.
◦ To ensure fair judgement, a Captain can only remove the Chief Justice with a majority vote from command.
◦ Warrants and court decisions must be written down and stamped with the notary stamp. Warrants must be approved by the Chief Justice.
◦ Full list of SoP changes can be found here: https://docs.google.com/document/d/12ZKTtzvVWBuC7PuiREL9v7mhVZve11p0-T6MBPpVeGs/edit?usp=sharing
• Classy wooden desk timer to help keep trials timely and within limits.
TO DO:
Chief Justice
Court Clerk
Prosecutor
SoP/Guidlines
Other
Notes:
Why / Balance
The current legal system in-game is built around LRP gameplay, with security handling everything relating to arrests, sentencing, trials, and execution. Additionally, it is near-impossible to find an impartial judge for any court case with the current system. New legal department would guarantee an impartial and available judge (whether it be the Chief Justice or Clerk) for any court case, take pressure off of security to handle things like sentencing and trials. Additionally, there will be more roleplay opportunities for things like civil cases, inter-department disputes, internal affairs, or whatever else you may need legal help with.
Technical details
n/a
Media
Breaking changes
none that I know of 😓
Changelog
🆑 Leo, Velcroboy, and Timemaster