Skip to content

ice bug in value of albedo solved #436

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JulienGroenenboom wants to merge 3 commits into
base: main
Choose a base branch
from
Open

ice bug in value of albedo solved #436

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e7a0eda
ice bug in value of albedo solved
goede2606 Dec 11, 2025
386e93e
Merge branch 'main' into fm/bugfix/UNST-9420_ice_bugfix_for_albedo_af…
goede2606 Dec 11, 2025
1f4abf8
UNST-9420: updated testcase reference results
thomas-pijls Dec 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/engines_gpl/dflowfm/packages/dflowfm_kernel/src/dflowfm_data/m_fm_icecover.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -469,6 +469,7 @@ subroutine update_icecover()
ice_area_fraction(n) = 1.0_fp
else
ice_thickness(n) = 0.0_fp
snow_thickness(n) = 0.0_fp
ice_area_fraction(n) = 0.0_fp
ice_temperature(n) = celsius_to_kelvin(0.0_fp)
end if
Expand Down
1 change: 1 addition & 0 deletions src/engines_gpl/dflowfm/packages/dflowfm_kernel/src/dflowfm_kernel/compute/heatun.f90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ subroutine heatun(n, time_in_hours, nominal_solar_radiation)
surface_temperature = kelvin_to_celsius(ice_temperature(n))
else
! no ice and no snow, but ice_modelling switched on
albedo = 0.06_fp ! Albedo is set to the albedo of water, in the same way as its initialization in m_heatfluxes.f90
surface_temperature = water_temperature_in_cell
end if
else
Expand Down
2 changes: 1 addition & 1 deletion test/deltares_testbench/configs/include/dimr_dflowfm_3d_cases.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,7 @@
</testCase>

<testCase name="e02_f020_c035_salinity_freezing_3d" ref="dflowfm_default">
<path version="2025-08-21T11:30:00.000000">e02_dflowfm/f020_heat_flux/c035_salinity_freezing_3d</path>
<path version="2025-12-12T14:35:26.545000">e02_dflowfm/f020_heat_flux/c035_salinity_freezing_3d</path>
<maxRunTime>60.0000000</maxRunTime>
<checks>
<file name="output/winter97_saltwater_his.nc" type="netCDF">
Expand Down
4 changes: 2 additions & 2 deletions test/deltares_testbench/configs/include/dimr_dflowfm_all_but_validation_cases.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2231,7 +2231,7 @@
</checks>
</testCase>
<testCase name="e02_f006_c176_freezing_with_background_salinity" ref="dflowfm_default">
<path version="2025-12-08T14:08:55.403000">e02_dflowfm/f006_external_forcing/c176_freezing_with_background_salinity</path>
<path version="2025-12-12T14:34:22.514000">e02_dflowfm/f006_external_forcing/c176_freezing_with_background_salinity</path>
<maxRunTime>3600.0</maxRunTime>
<checks>
<file name="output/winter97_saltwater-2_map.nc" type="netcdf">
Expand Down Expand Up @@ -4762,7 +4762,7 @@
</checks>
</testCase>
<testCase name="e02_f020_c034_salinity_freezing" ref="dflowfm_default">
<path version="2025-08-27T12:00:00">e02_dflowfm/f020_heat_flux/c034_salinity_freezing</path>
<path version="2025-12-12T14:33:06.073000">e02_dflowfm/f020_heat_flux/c034_salinity_freezing</path>
<maxRunTime>60.0000000</maxRunTime>
<checks>
<file name="output/winter97_saltwater_his.nc" type="netCDF">
Expand Down