Small fixes in set hazard methods #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ated it will be transformed
|
Santonia27
reviewed
Mar 10, 2025
| if "xc" in da.coords: | ||
| self.logger.warning("Hazard map is rotated. It will be reprojected to a none rotated grid using nearest neighbor interpolation") | ||
| da = da.raster.reproject(dst_crs=da.rio.crs) | ||
|
|
There was a problem hiding this comment.
I'm not fully familiar how the grid rotation works best, but according to chatgpt this code may fail if the crs is not in standard projection like UTM or WGS84. Maybe you could comment on that?
There was a problem hiding this comment.
It uses epsg codes from what I saw. So if there is an epsg code related to you projection it should work.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These changes ensure that when a rotated grid is provided it is automatically translated to a standard grid that FIAT can handle.