Skip to content

Small fixes in set hazard methods #425

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
panosatha merged 4 commits into from
Mar 12, 2025
Merged

Small fixes in set hazard methods #425

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
956ada1
some small checks to make sure that if the provided hazard map is rot…
panosatha Dec 6, 2024
181132e
Merge branch 'main' of https://github.com/Deltares/hydromt_fiat into …
panosatha Mar 3, 2025
940addb
Merge branch 'main' of https://github.com/Deltares/hydromt_fiat into …
panosatha Mar 7, 2025
118ff47
Merge branch 'main' of https://github.com/Deltares/hydromt_fiat into …
panosatha Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion hydromt_fiat/fiat.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -758,6 +758,15 @@ def setup_hazard(
da.encoding["_FillValue"] = None
da = da.raster.gdal_compliant()

# ensure variable name is lowercase, since FIAT seems to be failing if not # TODO check with FIAT
da_name = da_name.lower()
da = da.rename(da_name)

# Check if map is rotated and if yes, reproject to a non-rotated grid
if "xc" in da.coords:
self.logger.warning("Hazard map is rotated. It will be reprojected to a none rotated grid using nearest neighbor interpolation")
da = da.raster.reproject(dst_crs=da.rio.crs)

Copy link
Copy Markdown
Contributor

@Santonia27 Santonia27 Mar 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not fully familiar how the grid rotation works best, but according to chatgpt this code may fail if the crs is not in standard projection like UTM or WGS84. Maybe you could comment on that?

Copy link
Copy Markdown
Collaborator Author

@panosatha panosatha Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It uses epsg codes from what I saw. So if there is an epsg code related to you projection it should work.

# check masp projection, null data, and grids
check_maps_metadata(self.staticmaps, params, da, da_name, idx)

Expand Down Expand Up @@ -847,7 +856,7 @@ def setup_hazard(
)

self.set_config(
"hazard.elevation_reference", "dem" if da_type == "water_depth" else "datum"
"hazard.elevation_reference", "DEM" if da_type == "water_depth" else "datum"
)

# Set the configurations for a multiband netcdf
Expand Down