Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create preprocessing docs RibaMetaMod #68

Merged
merged 5 commits into from
Jul 5, 2024
Merged

Conversation

HendrikKok
Copy link
Contributor

No description provided.

@HendrikKok HendrikKok marked this pull request as ready for review July 2, 2024 10:11
@HendrikKok HendrikKok requested a review from rleander July 2, 2024 10:11
Copy link
Contributor

@rleander rleander left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

minor text suggestions

docs/coupler_ribametamod_preprocessing.qmd Show resolved Hide resolved
* the exchange files
* the iMOD coupler configuration file
* the optional logging configuration file

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the Ribasim model, the MetaSWAP model and the MODFLOW 6 model written here??
The foregoing suggests that only the interactions are being configured here
If that is the case plse remove the first three bullets

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No thats not the case. Primod even updated modelinput and then writes all models to file. I changed it to: the model input files,

docs/coupler_ribametamod_preprocessing.qmd Show resolved Hide resolved
docs/coupler_ribametamod_preprocessing.qmd Show resolved Hide resolved
docs/coupler_ribametamod_preprocessing.qmd Show resolved Hide resolved

Ribasim and MODFLOW
: For the flux exchange, the Overlay is based on the [river](https://deltares.github.io/imod-python/api/generated/mf6/imod.mf6.River.html) conductance. The indices are based on the package level. For the stage exchange, the mapping is based on the x and y locations of the [subgrid](https://deltares.github.io/Ribasim/reference/node/basin.html#subgrid) elements. For every [river](https://deltares.github.io/imod-python/api/generated/mf6/imod.mf6.River.html) conductance gridcell the neirest [subgrid](https://deltares.github.io/Ribasim/reference/node/basin.html#subgrid) element is found.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the Overlay -> the mapping (see further in that sentence)
Overlay -> mapping
all SVATS where -> all svats for which
grid based -> grid-based

Copy link
Contributor Author

@HendrikKok HendrikKok Jul 5, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I kept the overlay, because its referencing to line 179. SVATS are caps since its an abbreviation. Agree?

docs/coupler_ribametamod_preprocessing.qmd Outdated Show resolved Hide resolved
docs/coupler_ribametamod_preprocessing.qmd Outdated Show resolved Hide resolved
docs/coupler_ribametamod_preprocessing.qmd Show resolved Hide resolved
docs/coupler_ribametamod_preprocessing.qmd Show resolved Hide resolved
@HendrikKok HendrikKok requested a review from rleander July 5, 2024 11:15
@rleander rleander merged commit 6eeead5 into main Jul 5, 2024
1 of 2 checks passed
@rleander rleander deleted the add-examples-RibaMetaMod branch July 5, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants