Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create preprocessing docs RibaMetaMod #68
Create preprocessing docs RibaMetaMod #68
Changes from 2 commits
b3100a9
ace1b73
dbe30e5
30d404c
84602a1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are the Ribasim model, the MetaSWAP model and the MODFLOW 6 model written here??
The foregoing suggests that only the interactions are being configured here
If that is the case plse remove the first three bullets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No thats not the case. Primod even updated modelinput and then writes all models to file. I changed it to: the model input files,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This coupling requires the Basins in the Ribasim model to be set up with a subgrid [...]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what are water levels ? stages ? We should select one of these expresions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
potential for inconsistency -> a potential inconsistency
elevation: -> elevation,
subgridelelevation ->subgrid elevation
will stop -> stops
will proceed -> proceeds
will raise an error -> raises an error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
plse replace
This coupling is used for routing at the subsurface ->
by
This coupling is responsible for the surface runoff from the unsaturated zone.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
has the folowing requirements -> imposes the following requirement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whereas in general water users in Ribasim can have non-zero demands set at multiple priorities,
for water users this demand can only be positive at one priority and should be zero for others.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If Allocation ... alone -> should be in the technical doc
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
general:"
omit "will"
may -> can
terms define -> terms defined
simulation window -> domain
linked with Ribasim -> completely coupled to Ribasim
SVAT or svat ?? choose one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is an ABBREVIATED example ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
example for coupling Runoff -> example of coupling runoff
Takes -> Reads or the three reads on a line: Reads a Ribasim, MetaSWAP and MODFLOW 6 model
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
adition can be done -> addition is required
State that the driver_coupling_ribameta replaces the one in the upper part, but now with an extra basin definition for the water users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Exchange derivation -> Mapping definition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The mapping between MODFLOW 6 and MetaSWAP is based on matching grid-based coordinates.
The mapping between either MODFLOW 6 or MetaSWAP and Ribasim are based on a spatial overlap of a
Ribasim basin or water definition polygon. This polygon is provided as a geopandas.GeoDataFrame.
Mapping proceeds as follows:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reword the first two bullets:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the Overlay -> the mapping (see further in that sentence)
Overlay -> mapping
all SVATS where -> all svats for which
grid based -> grid-based
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I kept the overlay, because its referencing to line 179. SVATS are caps since its an abbreviation. Agree?