Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Otel #355

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

Otel #355

wants to merge 9 commits into from

Conversation

keithralphs
Copy link
Contributor

@keithralphs keithralphs commented Jan 31, 2024

An Illustration of various ways to instrument BlueAPI to add distributed tracing

!!!!!!! DO NOT MERGE !!!!!!!!

Copy link

codecov bot commented Feb 9, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (cad6bc0) 87.17% compared to head (08a539b) 87.65%.
Report is 4 commits behind head on main.

Files Patch % Lines
src/blueapi/tracing/tracing_utils.py 95.12% 2 Missing ⚠️
src/blueapi/messaging/stomptemplate.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #355      +/-   ##
==========================================
+ Coverage   87.17%   87.65%   +0.47%     
==========================================
  Files          42       44       +2     
  Lines        1645     1725      +80     
==========================================
+ Hits         1434     1512      +78     
- Misses        211      213       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stan-dot
Copy link
Collaborator

what stops this from merging? @keithralphs ?

@callumforrester
Copy link
Collaborator

@stan-dot I believe this PR is a demo/illustration, it was never intended to be merged. The intention was to make a PR for production if this approach was generally favoured.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants