Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove handler #538

Merged
merged 16 commits into from
Jul 23, 2024
Merged

Remove handler #538

merged 16 commits into from
Jul 23, 2024

Commits on Jul 23, 2024

  1. Remove handler 

    The handler has caused additional complexity with multiple levels of
indirection.

Remove the ABC and include the free functions in an "interface" module.

The main app and cli tests are rewritten to look more like unit tests.

This PR is to be followed up by further refactoring to replace the
singleton class with cached functions and restructuring the modules.

Fixes #434.
    @joeshannon
    joeshannon committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    2dedbfd View commit details
    Browse the repository at this point in the history

  2. Complete new test rest api

    @joeshannon
    joeshannon committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    ffa3d20 View commit details
    Browse the repository at this point in the history

  3. Fix interface signatures and add test

    @joeshannon
    joeshannon committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    25e870e View commit details
    Browse the repository at this point in the history

  4. Add other tests

    @joeshannon
    joeshannon committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    3ee8ff8 View commit details
    Browse the repository at this point in the history

  5. Revert to initial idea

    @joeshannon
    joeshannon committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    a943baf View commit details
    Browse the repository at this point in the history

  6. Fix ruff issues and simplify runner

    @joeshannon
    joeshannon committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f1dd82a View commit details
    Browse the repository at this point in the history

  7. Further cli tests

    @joeshannon
    joeshannon committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    45ad7af View commit details
    Browse the repository at this point in the history

  8. Finish proper test first pass

    @joeshannon
    joeshannon committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    f0bb377 View commit details
    Browse the repository at this point in the history

  9. Remove references to handler

    @joeshannon
    joeshannon committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e0c60ee View commit details
    Browse the repository at this point in the history

  10. Fix mypy errors

    @joeshannon
    joeshannon committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    3b3cddc View commit details
    Browse the repository at this point in the history

  11. Rename tests

    @joeshannon
    joeshannon committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    e7c4396 View commit details
    Browse the repository at this point in the history

  12. Add additional REST tests

    @joeshannon
    joeshannon committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    b1b0047 View commit details
    Browse the repository at this point in the history

  13. Rename Runner to WorkerDispatcher

    @joeshannon
    joeshannon committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    6ae803e View commit details
    Browse the repository at this point in the history

  14. Use dedent in test

    @joeshannon
    joeshannon committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    9862fa6 View commit details
    Browse the repository at this point in the history

  15. Set back to use subprocess by default and add test

    @joeshannon
    joeshannon committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    09f52d5 View commit details
    Browse the repository at this point in the history

  16. Ensure reloading on fail works properly 

    And add test.
    @joeshannon
    joeshannon committed Jul 23, 2024
    Configuration menu
    Copy the full SHA
    de535ac View commit details
    Browse the repository at this point in the history