-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove handler #538
Merged
Merged
Remove handler #538
Commits on Jul 23, 2024
-
The handler has caused additional complexity with multiple levels of indirection. Remove the ABC and include the free functions in an "interface" module. The main app and cli tests are rewritten to look more like unit tests. This PR is to be followed up by further refactoring to replace the singleton class with cached functions and restructuring the modules. Fixes #434.
Configuration menu - View commit details
-
Copy full SHA for 2dedbfd - Browse repository at this point
Copy the full SHA 2dedbfdView commit details -
Configuration menu - View commit details
-
Copy full SHA for ffa3d20 - Browse repository at this point
Copy the full SHA ffa3d20View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25e870e - Browse repository at this point
Copy the full SHA 25e870eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3ee8ff8 - Browse repository at this point
Copy the full SHA 3ee8ff8View commit details -
Configuration menu - View commit details
-
Copy full SHA for a943baf - Browse repository at this point
Copy the full SHA a943bafView commit details -
Configuration menu - View commit details
-
Copy full SHA for f1dd82a - Browse repository at this point
Copy the full SHA f1dd82aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 45ad7af - Browse repository at this point
Copy the full SHA 45ad7afView commit details -
Configuration menu - View commit details
-
Copy full SHA for f0bb377 - Browse repository at this point
Copy the full SHA f0bb377View commit details -
Configuration menu - View commit details
-
Copy full SHA for e0c60ee - Browse repository at this point
Copy the full SHA e0c60eeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 3b3cddc - Browse repository at this point
Copy the full SHA 3b3cddcView commit details -
Configuration menu - View commit details
-
Copy full SHA for e7c4396 - Browse repository at this point
Copy the full SHA e7c4396View commit details -
Configuration menu - View commit details
-
Copy full SHA for b1b0047 - Browse repository at this point
Copy the full SHA b1b0047View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6ae803e - Browse repository at this point
Copy the full SHA 6ae803eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9862fa6 - Browse repository at this point
Copy the full SHA 9862fa6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 09f52d5 - Browse repository at this point
Copy the full SHA 09f52d5View commit details -
Configuration menu - View commit details
-
Copy full SHA for de535ac - Browse repository at this point
Copy the full SHA de535acView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.