Remove handler #538
Merged
Remove handler #538
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #538 +/- ##
==========================================
- Coverage 91.51% 90.21% -1.31%
==========================================
Files 42 41 -1
Lines 1933 1829 -104
==========================================
- Hits 1769 1650 -119
- Misses 164 179 +15 ☔ View full report in Codecov by Sentry. |
joeshannon
force-pushed
the
434-remove-handler
branch
2 times, most recently
from
b04c12c
to
d200a0c
Compare
callumforrester
requested changes
Jul 11, 2024
joeshannon
force-pushed
the
434-remove-handler
branch
2 times, most recently
from
9dba177
to
4c480cc
Compare
joeshannon
force-pushed
the
434-remove-handler
branch
2 times, most recently
from
64bcaa2
to
81be95f
Compare
This was referenced Jul 23, 2024
The handler has caused additional complexity with multiple levels of indirection. Remove the ABC and include the free functions in an "interface" module. The main app and cli tests are rewritten to look more like unit tests. This PR is to be followed up by further refactoring to replace the singleton class with cached functions and restructuring the modules. Fixes #434.
joeshannon
force-pushed
the
434-remove-handler
branch
3 times, most recently
from
3794a34
to
533bea0
Compare
joeshannon
force-pushed
the
434-remove-handler
branch
from
533bea0
to
6ae803e
Compare
|
Had a play locally, when I reload the environment it doesn't appear to import new changes. |
joeshannon
force-pushed
the
434-remove-handler
branch
from
30774d2
to
de535ac
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove handler
The handler has caused additional complexity with multiple levels of
indirection.
Remove the ABC and include the free functions in an "interface" module.
The main app and cli tests are rewritten to look more like unit tests.
This PR is to be followed up by further refactoring to replace the
singleton class with cached functions and restructuring the modules.
Fixes #434.