Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update sonarcloud.yml with the condition for this repo instance #664

Merged
merged 1 commit into from
Oct 29, 2024

Conversation

stan-dot
Copy link
Collaborator

@stan-dot stan-dot commented Oct 11, 2024

The sonarcloud workflow requires an auth key, so will not work with PRs from forks, which we want to support. We will therefore skip that job when the PR is from a fork.

thanks @callumforrester

@stan-dot stan-dot self-assigned this Oct 11, 2024
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.62%. Comparing base (627ffc3) to head (d0bbe44).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #664   +/-   ##
=======================================
  Coverage   92.62%   92.62%           
=======================================
  Files          35       35           
  Lines        1654     1654           
=======================================
  Hits         1532     1532           
  Misses        122      122           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@callumforrester
Copy link
Collaborator

callumforrester commented Oct 11, 2024

Just to quickly document the reasons: The sonarcloud workflow requires an auth key, so will not work with PRs from forks, which we want to support. We will therefore skip that job when the PR is from a fork.

@stan-dot stan-dot force-pushed the sonarcloud-not-on-external-forks branch from f08748f to d0bbe44 Compare October 28, 2024 16:05
@stan-dot stan-dot merged commit 24c7e35 into main Oct 29, 2024
27 checks passed
@stan-dot stan-dot deleted the sonarcloud-not-on-external-forks branch October 29, 2024 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants