Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Bimorph Mirrors, Slits #315

Open
wants to merge 322 commits into
base: main
Choose a base branch
from

Conversation

dan-fernandes
Copy link

@dan-fernandes dan-fernandes commented Jan 30, 2024

Add Bimorph Mirrors, Slits Ophyd Devices

Instructions to reviewer on how to test:

  1. Create + activate venv

To test slits:

  1. Start the slit simulator (ask Daniel)
  2. Run pytest tests/devices/unit_tests/test_slit_interface.py
  3. Ensure all tests pass

To test bimorphs:

  1. SSH into BL02J
  2. Run pytest tests/devices/unit_tests/test_CAENels_bimorph_mirror_8_channel.py
  3. Ensure all tests pass

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards

…te parameter type hint from list[int] to list[float]
…t_and_proc_target_voltages now use and return Status objects
@DominicOram
Copy link
Contributor

I'm usually a bit ambivalent about squash vs. merge commits but in this case with 300+ commits can we make sure we squash it before we merge?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants