Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change type of robot error code PV #664

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Conversation

DominicOram
Copy link
Contributor

Part of DiamondLightSource/hyperion#1465

Instructions to reviewer on how to test:

  1. Run dodal connect i03
  2. Confirm robot is now happy

Checks for reviewer

  • Would the PR title make sense to a scientist on a set of release notes
  • If a new device has been added does it follow the standards
  • If changing the API for a pre-existing device, ensure that any beamlines using this device have updated their Bluesky plans accordingly
  • Have the connection tests for the relevant beamline(s) been run via dodal connect ${BEAMLINE}

Copy link
Collaborator

@olliesilvester olliesilvester left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I've noticed we have a few other places where we create epics signals with type int:

in fast_grid_scan smargon, tetramm, epics_util, xspress3, xspress3_channel

If we'd get a same issue for all of these, maybe we should change the rest of the devices too?

@DominicOram
Copy link
Contributor Author

Looks good, but I've noticed we have a few other places where we create epics signals with type int:

in fast_grid_scan smargon, tetramm, epics_util, xspress3, xspress3_channel

If we'd get a same issue for all of these, maybe we should change the rest of the devices too?

For most of these they're not an ao record in EPICS, they're either longs or binary. You could argue that we shouldn't be using ints at all for the binary ones I guess but the longs are fine. Basically, if the device connects then it's fine. All these devices connect when we do dodal connect i03 except the tetramm, which seems fine when I do dodal connect i22.

@DominicOram DominicOram merged commit 36e289a into main Jul 10, 2024
11 checks passed
@DominicOram DominicOram deleted the fix_robot_error_code_type branch July 10, 2024 13:55
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants