Update with master #425
Open
Update with master #425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tweak some css for long axis names on the frame selector
Add a setting to adjust the login message.
Don't show the context menu when finishing an annotation.
Hitting escape while drawing a polygon annotation left the draw tool in an odd state. This also resolves #378.
Harden drawing annotations.
Update README
Add an admin endpoint for querying files.
Harden switching annotation modes
If you switched out of shape edit mode when having a shade draw mode selected (e.g., polygon), odd things could happen until the mode was cycled once.
Adjust position and z-index of region control dropdown
Show a loading spinner until the image is ready.
Update ruff commands
Pull plotly package as part of the build process rather than on-demand so that it loads faster
Use new plottable data endpoints from large_image
Fix plottable data tests
Increase size of loading spinner
This happens if the number of distinct values is longer with adjacent items
Fix an issue with the distinct plottable list color
Fix a check if we can group by two different values for violin plots
…romise Fix a condition where the plottable data promise could be null
Fix a test based on a change in the large_image client
Guard resource path lookups
naglepuff
force-pushed
the
update-with-master
branch
from
aadaf50
to
8ad50fd
Compare
naglepuff
commented
Oct 17, 2024
histomicsui/handlers.py
Outdated
There was a problem hiding this comment.
This file seems to have changed a lot between master and girder-5. It looks like process_annotations was replaced by process_annotations_task, and process_annotations has gotten some updates in master, checking for file size from the config. (process_annotations_task seems to read the entire file in chunks no matter what).
Should I port the changes from master over to process_annotations_task? (i.e. import large_image.config, and copy over the logic?)
There was a problem hiding this comment.
I decided to move the changes over in dc43dfc. It looks like large_image.config.getConfig can already work with environment variables.
If there are any objections let me know, I can revert the commit.
naglepuff
commented
Oct 17, 2024
This requires an appropriately new version in large_image. Future work is to support app icons. Those should probably be configurable before any are merged in.
Add and support app buttons.
Load settings earlier.
Update CI to handle a large-image mocking change
Update precommit packages
Add a pyproject.toml base to reduce pip 24.2 warnings
Ported over from the master branch since merging didn't bring this change from @manthey in.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bring the
girder-5branch up to date with changes frommaster