-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds MAM4xx: Aerosol wet scavenging interface #2848
base: master
Are you sure you want to change the base?
Adds MAM4xx: Aerosol wet scavenging interface #2848
Conversation
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
2 similar comments
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
@odiazib , is this a WIP PR? |
@susburrows . Yes, it is. I removed the label WIP so I can run the auto tester. I will check that tests are passing in weaver/mappy. Then, this PR will be ready for review. |
Sounds good! Please send me an email when it's ready for me to look at. |
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed. |
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: odiazib |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
SCREAM_PullRequest_Autotester_Mappy # 5477 FAILED (click to see last 100 lines of console output)
SCREAM_PullRequest_Autotester_Weaver # 5754 FAILED (click to see last 100 lines of console output)
|
…d namelist yaml files with new var names
Status Flag 'Pre-Test Inspection' - - This Pull Request Requires Inspection... The code must be inspected by a member of the Team before Testing/Merging |
0e93c11
to
6de6c33
Compare
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pre-Test Inspection' - SUCCESS: The last commit to this Pull Request has been INSPECTED by label AT: PRE-TEST INSPECTED! Autotester is Removing Label; this inspection will remain valid until a new commit to source branch is performed. |
Status Flag 'Pull Request AutoTester' - User Requested Retest - Label AT: RETEST will be reset after testing. |
Status Flag 'Pull Request AutoTester' - Testing Jenkins Projects: Pull Request Auto Testing STARTING (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
Using Repos:
Pull Request Author: odiazib |
Status Flag 'Pull Request AutoTester' - Jenkins Testing: 1 or more Jobs FAILED Note: Testing will normally be attempted again in approx. 2 Hrs. If a change to the PR source branch occurs, the testing will be attempted again on next available autotester run. Pull Request Auto Testing has FAILED (click to expand)Build InformationTest Name: SCREAM_PullRequest_Autotester_Mappy
Jenkins Parameters
Build InformationTest Name: SCREAM_PullRequest_Autotester_Weaver
Jenkins Parameters
SCREAM_PullRequest_Autotester_Mappy # 5625 FAILED (click to see last 100 lines of console output)
SCREAM_PullRequest_Autotester_Weaver # 5871 FAILED (click to see last 100 lines of console output)
|
We are adding the
emaxx-mam4xx
interface for the aerosol wet scavenging process (mam4_wetscav
). This interface computesaerdepwetis
andaerdepwetcw
; these variables are used to calculate surface fluxes required by the land model. Cloud-borne and interstitial aerosol mixing ratios are also updated by this routine. Finally, this routine calculates wet aerosol diameter, aerosol particle diameter, aerosol water mixing ratio, and wet aerosol density.This interface invokes the mam4xx
aero_model_wetdep
routine. This routine is part of mam4xx and invokes themodal_aero_calcsize_sub
andwater_modal_aero_water_uptake_dr
routines, as well as the core of the wet deposition routines. The inputs and outputs for this routine are presented next.Inputs:
cldfrac_liq
precip_total_tend
nevapr
In/Out:
wetdep_hydrophilic_bc
drydep_hydrophilic_bc
wetdep_hydrophilic_oc
drydep_hydrophilic_oc
wetdep_dust_bin1
wetdep_dust_bin2
wetdep_dust_bin3
wetdep_dust_bin4
Interstitial and cloud borne aerosols
Output:
dgncur_a
qaerwat
wetdens
dgnumwet
aerdepwetis
aerdepwetcw
Testing
We have included four SCREAM standalone tests, one for a single process and 3 for multiple processes. These tests are running correctly on both CPUs and GPUs, as reported by the autotester (AT). Note that the baseline tests for these are failing because we have not created these baselines yet.
wetscav
process is added as an EAMxx process with the ability to turn it on/off using the labelmam4_wetscav
in the namelist_scream.xml file. The atmchange command to invoke this process in a CIME simulation is:./atmchange physics::atm_procs_list="mac_aero_mic,mam4_wetscav,rrtmgp"
To run a CIME simulation, we have created a test modifier
mam4xx-wetscav
:Where,
is the machine name
is the compiler to use on the machine
is a unique string test identifier
is the allocation project to charge
Validation in mam4xx.
We have created a validation test for aero_model_wetdep that utilizes data generated by E3SM v2 and using Skywalker. Additionally, all subroutines within aero_model_wetdep were verified using data generated by E3SM v2 and using Skywalker.
Important notes:
1. TODO: We need to connect the output from this process to land aerosol fluxes. We will do that in a follow-up PR (see issue #2888 ).