Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds MAM4xx: Aerosol wet scavenging interface #2848

Merged
merged 71 commits into from
Jul 30, 2024
Merged

Adds MAM4xx: Aerosol wet scavenging interface #2848

merged 71 commits into from
Jul 30, 2024

Commits on Jul 6, 2024

  1. wet_scav - get code from balwinder branch.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    636c765 View commit details
    Browse the repository at this point in the history

  2. wet_scav - update interface

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    61fb835 View commit details
    Browse the repository at this point in the history

  3. wet_scav - using compute_calcsize_and_water_uptake_dr

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    912e0bc View commit details
    Browse the repository at this point in the history

  4. wet_scav - delete old code.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    68c9a9d View commit details
    Browse the repository at this point in the history

  5. wet_scav - remove private member of parallel_for

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    cc8ecaf View commit details
    Browse the repository at this point in the history

  6. wet_scav - add dig variables. Unit tests is working.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    9818035 View commit details
    Browse the repository at this point in the history

  7. wet_scav - update interface

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    7d3cbff View commit details
    Browse the repository at this point in the history

  8. wet_scav - test is working in cpu/gpus.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    8363b75 View commit details
    Browse the repository at this point in the history

  9. wet_scav - adding single-process.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    604c2fa View commit details
    Browse the repository at this point in the history

  10. wet_dep - update to match mam4xx interface.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    d0db05b View commit details
    Browse the repository at this point in the history

  11. wet_dep - update mam4xx interface.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    1ac385d View commit details
    Browse the repository at this point in the history

  12. wet_dep - update name of tendencies.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    c5c0cfa View commit details
    Browse the repository at this point in the history

  13. wet_scav - rebase code

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    593c8b1 View commit details
    Browse the repository at this point in the history

  14. wet_scav - adding missing input variable.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    a76689c View commit details
    Browse the repository at this point in the history

  15. wet_scav - removing old comments and variables that not needed.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    5cd64ae View commit details
    Browse the repository at this point in the history

  16. wet_scav - updating code after rebase.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    711199b View commit details
    Browse the repository at this point in the history

  17. wet_scav - Adding missing variables in input file.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    1b80528 View commit details
    Browse the repository at this point in the history

  18. wet_scav - Moving 'aerdepwetis' and 'aerdepwetcw' to the field manage… 

    …r and adding them to the output.yaml file.
    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    8ec139c View commit details
    Browse the repository at this point in the history

  19. wet_scav - Removing headers that are part of mam_coupling and unused … 

    …views.
    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    7ced79a View commit details
    Browse the repository at this point in the history

  20. wet_scav - Adding output fields.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    6b6a79d View commit details
    Browse the repository at this point in the history

  21. wet_scav - Adding outputs and running test for 3 steps.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    d39659a View commit details
    Browse the repository at this point in the history

  22. wet_sav- removin unused input.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    6e81baa View commit details
    Browse the repository at this point in the history

  23. wet_sav - Adding FIXME.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    5b0b243 View commit details
    Browse the repository at this point in the history

  24. wet_sav - Updating comments.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    6e55317 View commit details
    Browse the repository at this point in the history

  25. wet_scav - Setting Frequency=2

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    8cd04d2 View commit details
    Browse the repository at this point in the history

  26. wet_scav - Adding multi-process test for mam4_wetsav.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    e91b2e2 View commit details
    Browse the repository at this point in the history

  27. wet_sav - Adding wetscav to namelist.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    2570f06 View commit details
    Browse the repository at this point in the history

  28. wet_scav - Removing initial values of pbl_height and phis from nameli… 

    …st_defaults_scream.xml. Upgrading MAM4xx.
    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    7b1471d View commit details
    Browse the repository at this point in the history

  29. wet_scav - Adding line in CMakeLists.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    25d4a91 View commit details
    Browse the repository at this point in the history

  30. wet_scav - Update interstitial aerosol state.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    3e6bf35 View commit details
    Browse the repository at this point in the history

  31. A working CIME case with wetscav in the process list at the right place

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    a55b7a7 View commit details
    Browse the repository at this point in the history

  32. Fixes single process test

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    7299556 View commit details
    Browse the repository at this point in the history

  33. Fixes file for the mam4xx standalone tests

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    cf73f93 View commit details
    Browse the repository at this point in the history

  34. Removing uncoupled test files since they are renamed as single proces… 

    …s tests
    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    f65792d View commit details
    Browse the repository at this point in the history

  35. Clang format and makes dp_frac and input, updates mam4xx submodule to… 

    … point to a branch
    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    0327c9e View commit details
    Browse the repository at this point in the history

  36. Makes cldt intent-in (include changes to the mam4xx submodule)

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    14efd0d View commit details
    Browse the repository at this point in the history

  37. Makes some more convective fields intent-in (updates submodule mam4xx)

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    6ada930 View commit details
    Browse the repository at this point in the history

  38. Fixes some more vars to be intent-in (mam4xx submodule updated)

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    04ae764 View commit details
    Browse the repository at this point in the history

  39. Moved around variables to match I/O-1

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    b4ffbe9 View commit details
    Browse the repository at this point in the history

  40. Removes ptend from output FM and some cleanup for I/O-2

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    abd75db View commit details
    Browse the repository at this point in the history

  41. Done with the initialize_impl method cleanup

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    6c819c8 View commit details
    Browse the repository at this point in the history

  42. Rebased on current master

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    3e73b8f View commit details
    Browse the repository at this point in the history

  43. Completed a round of cleanup- variables rearranged to match i/o-3

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    f52f628 View commit details
    Browse the repository at this point in the history

  44. Adds a multi-process test: p3-wetscav

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    870e978 View commit details
    Browse the repository at this point in the history

  45. Adds missing files for the new multi-process test

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    8a81e1c View commit details
    Browse the repository at this point in the history

  46. Adds another multi-process test for wetscav

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    64fc5a3 View commit details
    Browse the repository at this point in the history

  47. updated submodule to a newer version

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    0ec3227 View commit details
    Browse the repository at this point in the history

  48. Cleans wetscav hpp file and minor changes to the cpp file

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    d00cd50 View commit details
    Browse the repository at this point in the history

  49. Adds descriptive var names; removes conv vars from FM; fixes input an… 

    …d namelist yaml files with new var names
    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    dd7e21b View commit details
    Browse the repository at this point in the history

  50. Adds const for input vars, removes scorpio temp change

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    e6610dd View commit details
    Browse the repository at this point in the history

  51. Cleans up namelist xml file and removes double ICs

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    8c7d2a7 View commit details
    Browse the repository at this point in the history

  52. Removes a left over comment

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    83a85eb View commit details
    Browse the repository at this point in the history

  53. Minor change in comments

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    140ee78 View commit details
    Browse the repository at this point in the history

  54. wet_scav - Removing Kokkos::resize.

    @odiazib @singhbalwinder
    odiazib authored and singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    aed9ffc View commit details
    Browse the repository at this point in the history

  55. Fixes some test fails: remove old output varnames, fixed output nc fi… 

    …le name
    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    019a54c View commit details
    Browse the repository at this point in the history

  56. Adds TODO to a comment as some editors can highlight these comments

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    fe66519 View commit details
    Browse the repository at this point in the history

  57. Fixes previous commit: Adds a TODO comment here

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    af58453 View commit details
    Browse the repository at this point in the history

  58. Adds a new function to add additional tracers for MAM4xx

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    4d3b7bc View commit details
    Browse the repository at this point in the history

  59. Adds the new script for computing number of tracers

    @singhbalwinder
    singhbalwinder committed Jul 6, 2024
    Configuration menu
    Copy the full SHA
    6de6c33 View commit details
    Browse the repository at this point in the history

Commits on Jul 7, 2024

  1. Fixes script to update tracer number in scream cmake options

    @singhbalwinder
    singhbalwinder committed Jul 7, 2024
    Configuration menu
    Copy the full SHA
    54f7110 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2024

  1. Adds missing call to update the state (int and cldbrn aerosols)

    @singhbalwinder
    singhbalwinder committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    b00a709 View commit details
    Browse the repository at this point in the history

  2. Updates number mixing ratios for state

    @singhbalwinder
    singhbalwinder committed Jul 12, 2024
    Configuration menu
    Copy the full SHA
    4734cac View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2024

  1. Zero out tends before computing tends as they had junk values

    @singhbalwinder
    singhbalwinder committed Jul 13, 2024
    Configuration menu
    Copy the full SHA
    1323ea6 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2024

  1. Ensure that Kokkos::deep_copy is called outside of parallel_for.

    @odiazib
    odiazib committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    f8e206d View commit details
    Browse the repository at this point in the history

  2. wet_scav - Fixing compilation errors.

    @odiazib
    odiazib committed Jul 15, 2024
    Configuration menu
    Copy the full SHA
    9cb990c View commit details
    Browse the repository at this point in the history

Commits on Jul 19, 2024

  1. Updates mam4xx submodule-pointed to main for wetscav qqcw update

    @singhbalwinder
    singhbalwinder committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    047802b View commit details
    Browse the repository at this point in the history

  2. Submodule update: declare local vrs for device code

    @singhbalwinder
    singhbalwinder committed Jul 19, 2024
    Configuration menu
    Copy the full SHA
    c75615f View commit details
    Browse the repository at this point in the history

Commits on Jul 29, 2024

  1. Changes due to code review feedback.

    @overfelt
    overfelt committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    1f77bf0 View commit details
    Browse the repository at this point in the history

  2. Changes due to code review feedback.

    @overfelt
    overfelt committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    2890ec1 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Changes due to code review feedback.

    @overfelt
    overfelt committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    8fd0eae View commit details
    Browse the repository at this point in the history

  2. Revert "Changes due to code review feedback." 

    This reverts commit 8fd0eae.

There are fields that need to be in the FieldManager since
this is still in the evaluation stage.
    @overfelt
    overfelt committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    29d83eb View commit details
    Browse the repository at this point in the history