Add Postcard Codec #20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surban
requested changes
Jul 14, 2024
| let mut bytes = vec![]; | ||
| reader.read_to_end(&mut bytes).map_err(DeserializationError::new)?; | ||
|
|
||
| let item = postcard::from_bytes(&bytes).map_err(DeserializationError::new)?; |
There was a problem hiding this comment.
Would it be possible to use postcard::from_io here instead?
We want to avoid keeping the whole incoming data in a memory buffer, if possible.
There was a problem hiding this comment.
I tried that initially but it required us to pass in a sized slice that is big enough to fit all the data to be deserialised. I could have done something like
let mut bytes = [0; 2048];
postcard::from_io((reader, &mut bytes))...
But I figured that would cause more problems than it's worth.
There was a problem hiding this comment.
A bit unfortunate, but probably the best we can do for now.
There was a problem hiding this comment.
Yeah, it's kind of annoying. Maybe I can circle back if postcard makes any further amendments to their API to address this.
I'll raise an issue with them about it.
surban
approved these changes
Jul 14, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.