Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Xref Mapping New pipeline #980

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

TamaraNaboulsi
Copy link
Member

Any pull request that does not include enough information to be reviewed in a timely manner may be closed at the maintainers' discretion

Requirements

  • Filling out the template is required.
  • Review the contributing guidelines for this repository; remember in particular:
    • do not modify code without testing for regression
    • provide simple unit tests to test the changes
    • if you change the schema you must patch the test databases as well, see Updating the schema
    • the PR must not fail unit testing

Description

New xref mapping pipeline written in Nextflow and python, as well as fixes and improvement to the download pipeline.

Use case

This PR contains the next step of the xref refactoring and rewriting using Nextflow and python, which started with the download part and now the mapping part. The general flow of the pipeline is still the same. Various improvements and fixes for long-standing issues have been added. In addition, a test suite was added, though it doesn't cover every module yet. The Confluence page for the new xref pipelines has been updated.

The new pipeline has been tested on multiple vertebrate and plant species, both independently and together, and is working as expected. It has also been tested with human and mouse (along with the modified download pipeline for gencode), though few issues are still being checked.

Benefits

New pipeline with new technologies.

Possible Drawbacks

Refer to "Known Issues" section in Confluence page.

Testing

  • Have you added/modified unit tests to test the changes?
  • If so, do the tests pass?
  • Have you run the entire test suite and no regression was detected?
  • TravisCI passed on your branch

Dependencies

If applicable, define what code dependencies were added and/or updated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant