Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor login system #1919

Merged
merged 46 commits into from
Jul 24, 2024
Merged

Refactor login system #1919

merged 46 commits into from
Jul 24, 2024

Conversation

SidharthK2
Copy link
Contributor

@SidharthK2 SidharthK2 commented Jul 4, 2024

Refactor Login

  • Added new magic connector
  • Use WAGMI, Viem 1.x for compatibility with stable magic-wagmi connector
  • Updated Logout functionality
  • Prevent redirect loop when token isn't signed
  • Fixed network switch toast popping early
  • Fixed publish button not disabled for non-WL wallets

How should this be tested?

  • Try to login/logout using both magic and wallet
  • Edit/publish wiki
  • Wallet balance
  • Whitelist status

Linked issues

closes EveripediaNetwork/issues#2849
closes EveripediaNetwork/issues#2869

Copy link

stackblitz bot commented Jul 4, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Jul 4, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
iq-wiki ✅ Ready (Inspect) Visit Preview Jul 24, 2024 10:44am

package.json Show resolved Hide resolved
@Royal-lobster
Copy link
Member

Dope the login happens smooth now ! tho found some issues: (which may be not related to this one)

  1. The avatar is not getting ens avatar
    CleanShot 2024-07-16 at 16 54 24
    CleanShot 2024-07-16 at 16 54 21@2x

  2. I am able to edit wikis but unable to create new ones, when i do , the button won't work, when i try to reload, it redirects me to login page and won't let me go past it

CleanShot.2024-07-16.at.16.57.19.mp4

@SidharthK2
Copy link
Contributor Author

Dope the login happens smooth now ! tho found some issues: (which may be not related to this one)

  1. The avatar is not getting ens avatar
    CleanShot 2024-07-16 at 16 54 24
    CleanShot 2024-07-16 at 16 54 21@2x
  2. I am able to edit wikis but unable to create new ones, when i do , the button won't work, when i try to reload, it redirects me to login page and won't let me go past it

CleanShot.2024-07-16.at.16.57.19.mp4

  • I disabled ENS fetching on iqchain, tho we can make calls to ethereum on dev also.
  • Will look into it, I was able to create wiki tho last I tried.

@SidharthK2 SidharthK2 merged commit 4ec09d3 into main Jul 24, 2024
2 checks passed
@SidharthK2 SidharthK2 deleted the refactor/login-system branch July 24, 2024 10:45
@SidharthK2 SidharthK2 restored the refactor/login-system branch July 24, 2024 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants