Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restructure Search Navigation To Allow users Suggest Wiki #1925

Merged
merged 6 commits into from
Jul 11, 2024

Conversation

Damola18
Copy link
Contributor

@Damola18 Damola18 commented Jul 8, 2024

Restructure Search Navigation To Suggest Wiki

This PR:

  • Allow users to suggest wiki when the wiki searched is not found
  • Updates wiki search for suggestions on settings notifications page
  • Fixes menu that doesn't close on mobile.
  • Prepopulates the suggest wiki field with the query from the search field when searched wiki is not found

Before

Menu doesnt close when create-wiki button is triggered

Screen.Recording.2024-07-08.at.16.53.43.mov

After

Screen.Recording.2024-07-08.at.16.41.55.mov

Prepopulated suggest wiki field with the query from search field

Screen.Recording.2024-07-11.at.12.24.48.mov

image

Updated wiki suggestion on settings notifications page

image

Linked issues

closes EveripediaNetwork/issues#2872

Copy link

stackblitz bot commented Jul 8, 2024

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

Copy link

vercel bot commented Jul 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
iq-wiki ✅ Ready (Inspect) Visit Preview Jul 11, 2024 7:43am

Copy link
Contributor

@Tolu-Mals Tolu-Mals left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👏🏾

Copy link
Member

@Softdev1 Softdev1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and works fine

@Damola18 Damola18 changed the title Fix search wikis Restructure Search Navigation To Allow users Suggest Wiki Jul 11, 2024
@Damola18 Damola18 merged commit 1ee9320 into main Jul 11, 2024
2 checks passed
@Damola18 Damola18 deleted the fix-search-wikis branch July 11, 2024 11:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants