Skip to content

Conversation

@yyezzzyy
Copy link
Collaborator

메리크리스마스 ~ 🎄

@yyezzzyy yyezzzyy self-assigned this Dec 24, 2024
@github-actions
Copy link

github-actions bot commented Dec 24, 2024

💄 Storybook: https://673dcf13c9a3a1189a7c6fd4-kagagnrpbh.chromatic.com/ # Chromatic에서 생성된 Storybook URL
🕖 Update: 2024년 12월 26일 00시 20분 29초 # 현재 시간

Copy link
Contributor

@cccwon2 cccwon2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

메리 크리스마스~

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image
태블릿 사이즈일때 글씨 크기가 좀 큰거같아요!

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

모바일일때 인디게이터랑 간섭이 있습니다
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

인디게이터 클릭했을때 해당 섹션으로 이동이 된다면 더 좋을거같아요!
지금은 호버했을때 스타일은 바뀌는데 클릭했을때 동작은 따로 없는거같네용?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

넵 없어요 근데 요런 랜딩페이지는 구간마다 링크설정은따로 안해도 될것 같은데 어떤가용🤔
랜딩페이지라 검색 엔진이나 광고성 디자인, 사용자가 얻을 수 있는 혜택에 관한 간단명료한 설명만 있으면 될 것 같아서요 !

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

아항 그렇다면 제생각에는 호버했을때 스타일이 없는게 자연스러울거같습니다!

const [isSideMenuOpen, setIsSideMenuOpen] = useState(false);
const router = useRouter();

if (pathname === "/") {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

랜딩페이지에서 로그인/회원가입 으로 갈수있는 버튼이 있어야할거같아요

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

헤더에 보이는건 별로라 지금바로 시작하세요에 걸어놨어용

Copy link
Collaborator

@hongggyelim hongggyelim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 예뿌네용

@hongggyelim hongggyelim merged commit 4908a54 into dev Dec 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants