-
Notifications
You must be signed in to change notification settings - Fork 5
design: landing fix #249
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
design: landing fix #249
Changes from 11 commits
Commits
Show all changes
20 commits
Select commit
Hold shift + click to select a range
3778a5a
design: 랜딩페이지 수정
yyezzzy 96e5b1c
Merge branch 'dev' of https://github.com/FE9-2/workroot into design/l…
yyezzzy 19f1df1
design: tailwind 수정
yyezzzy 488aa55
design: color 수정
yyezzzy 272d98f
Merge branch 'dev' of https://github.com/FE9-2/workroot into design/l…
yyezzzy f0f1640
Merge branch 'dev' of https://github.com/FE9-2/workroot into design/l…
yyezzzy 56d8467
chore: og-image 교체
yyezzzy c9a9410
design: 랜딩페이지 수정
yyezzzy 7fb4410
design: 수정
yyezzzy 7e4ec0f
Merge branch 'dev' of https://github.com/FE9-2/workroot into design/l…
yyezzzy 1e62feb
chore: 오타 수정
yyezzzy 1b311ce
chore: 랜딩페이지 이미지 수정
yyezzzy 4b2a6c0
chore: 이미지 수정
yyezzzy b6523b0
chore: 사진 수정
yyezzzy 0027045
랜딩페이지 수정
yyezzzy d68beb7
design: LeafAnimation 추가
yyezzzy f183087
수정
yyezzzy 351cd3c
design: 랜딩페이지 수정
yyezzzy f8c4684
design: react-lottie 수정
yyezzzy 0f5182b
design: lottie 수정
yyezzzy File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -20,6 +20,29 @@ export default function Header() { | |
| const [isSideMenuOpen, setIsSideMenuOpen] = useState(false); | ||
| const router = useRouter(); | ||
|
|
||
| if (pathname === "/") { | ||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 랜딩페이지에서 로그인/회원가입 으로 갈수있는 버튼이 있어야할거같아요
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 헤더에 보이는건 별로라 지금바로 시작하세요에 걸어놨어용 |
||
| return ( | ||
| <header className="fixed left-0 right-0 top-0 z-40" data-slide-header> | ||
| <nav className="mx-auto flex h-16 min-w-[327px] max-w-screen-xl items-center justify-end px-6"> | ||
| <div className="flex items-center gap-4 md:gap-6"> | ||
| <Link | ||
| href="/work-list" | ||
| className="text-sm text-white transition-colors hover:text-lime-400 md:text-base lg:text-lg" | ||
| > | ||
| 워크 채널 | ||
| </Link> | ||
| <Link | ||
| href="/work-talk" | ||
| className="text-sm text-white transition-colors hover:text-lime-400 md:text-base lg:text-lg" | ||
| > | ||
| 워크톡 | ||
| </Link> | ||
| </div> | ||
| </nav> | ||
| </header> | ||
| ); | ||
| } | ||
|
|
||
| // 인증이 필요없는 공개 경로들 | ||
| const handleLogout = async (e: React.MouseEvent<HTMLAnchorElement>) => { | ||
| e.preventDefault(); | ||
|
|
@@ -52,7 +75,7 @@ export default function Header() { | |
| return ( | ||
| <header className={headerStyle}> | ||
| <nav className={navStyle}> | ||
| {/* 로고와 메인 네비게이션 */} | ||
| {/* 로고의 메인 네비게이션 */} | ||
| <div className="flex items-center"> | ||
| <Link href="/" className="flex items-center gap-[6px] text-xl"> | ||
| <Image | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
태블릿 사이즈일때 글씨 크기가 좀 큰거같아요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
모바일일때 인디게이터랑 간섭이 있습니다

There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
인디게이터 클릭했을때 해당 섹션으로 이동이 된다면 더 좋을거같아요!
지금은 호버했을때 스타일은 바뀌는데 클릭했을때 동작은 따로 없는거같네용?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
넵 없어요 근데 요런 랜딩페이지는 구간마다 링크설정은따로 안해도 될것 같은데 어떤가용🤔
랜딩페이지라 검색 엔진이나 광고성 디자인, 사용자가 얻을 수 있는 혜택에 관한 간단명료한 설명만 있으면 될 것 같아서요 !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
아항 그렇다면 제생각에는 호버했을때 스타일이 없는게 자연스러울거같습니다!