Open
Conversation
Create class for Ultrasonic Sensor. #14 Further tuning would be needed once sensor is located.
Contributor
georgetzavelas
left a comment
georgetzavelas
left a comment
There was a problem hiding this comment.
Great first step Khadeeja! Unfortunately the file is empty :(
| * proportional control to maintain a set distance from an object. | ||
| */ | ||
|
|
||
| public class UltrasonicSensor extends TimedRobot { |
Contributor
There was a problem hiding this comment.
Can you take a look at the other Sensors in the code and try to implement the Sendable interface?
Author
There was a problem hiding this comment.
i'm working on it straight away!
nicojopr
requested changes
Feb 22, 2020
Contributor
nicojopr
left a comment
nicojopr
left a comment
There was a problem hiding this comment.
As suggested by George and previously by Charlie, please follow the Sendable pattern
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create class for Ultrasonic Sensor. #14
Further tuning would be needed once sensor is located.