-
Notifications
You must be signed in to change notification settings - Fork 2
Ultrasonic Sensor is ready #101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
khadeeja2005
wants to merge
3
commits into
master
Choose a base branch
from
Ultrasonic-Sensor
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,60 @@ | ||
| /*----------------------------------------------------------------------------*/ | ||
| /* Copyright (c) 2017-2019 FIRST. All Rights Reserved. */ | ||
| /* Open Source Software - may be modified and shared by FRC teams. The code */ | ||
| /* must be accompanied by the FIRST BSD license file in the root directory of */ | ||
| /* the project. */ | ||
| /*----------------------------------------------------------------------------*/ | ||
|
|
||
| package frc.robot.sensors; | ||
|
|
||
| import edu.wpi.first.wpilibj.AnalogInput; | ||
| import edu.wpi.first.wpilibj.MedianFilter; | ||
| import edu.wpi.first.wpilibj.PWMVictorSPX; | ||
| import edu.wpi.first.wpilibj.TimedRobot; | ||
| import edu.wpi.first.wpilibj.drive.DifferentialDrive; | ||
|
|
||
| /** | ||
| * This is a sample program demonstrating how to use an ultrasonic sensor and | ||
| * proportional control to maintain a set distance from an object. | ||
| */ | ||
|
|
||
| public class UltrasonicSensor extends TimedRobot { | ||
| // distance in inches the robot wants to stay from an object | ||
| private static final double kHoldDistance = 12.0; | ||
|
|
||
| // factor to convert sensor values to a distance in inches | ||
| private static final double kValueToInches = 0.125; | ||
|
|
||
| // proportional speed constant | ||
| private static final double kP = 0.05; | ||
|
|
||
| private static final int kLeftMotorPort = 0; | ||
| private static final int kRightMotorPort = 1; | ||
| private static final int kUltrasonicPort = 0; | ||
|
|
||
| // median filter to discard outliers; filters over 10 samples | ||
| private final MedianFilter m_filter = new MedianFilter(10); | ||
|
|
||
| private final AnalogInput m_ultrasonic = new AnalogInput(kUltrasonicPort); | ||
| private final DifferentialDrive m_robotDrive | ||
| = new DifferentialDrive(new PWMVictorSPX(kLeftMotorPort), | ||
| new PWMVictorSPX(kRightMotorPort)); | ||
|
|
||
| /** | ||
| * Tells the robot to drive to a set distance (in inches) from an object | ||
| * using proportional control. | ||
| */ | ||
| @Override | ||
| public void teleopPeriodic() { | ||
| // sensor returns a value from 0-4095 that is scaled to inches | ||
| // returned value is filtered with a rolling median filter, since ultrasonics | ||
| // tend to be quite noisy and susceptible to sudden outliers | ||
| double currentDistance = m_filter.calculate(m_ultrasonic.getValue()) * kValueToInches; | ||
|
|
||
| // convert distance error to a motor speed | ||
| double currentSpeed = (kHoldDistance - currentDistance) * kP; | ||
|
|
||
| // drive robot | ||
| m_robotDrive.arcadeDrive(currentSpeed, 0); | ||
| } | ||
| } | ||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you take a look at the other Sensors in the code and try to implement the Sendable interface?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i'm working on it straight away!