-
Notifications
You must be signed in to change notification settings - Fork 269
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --fabric.addMods / -Dfabric.addMods for adding extra path separator separated mods, list file if prefixed with @ #470
Conversation
…or separated mods, list file if prefixed with @
src/main/java/net/fabricmc/loader/impl/discovery/ArgumentModCandidateFinder.java
Outdated
Show resolved
Hide resolved
src/main/java/net/fabricmc/loader/impl/util/SystemProperties.java
Outdated
Show resolved
Hide resolved
Looks good to me :) |
@@ -118,6 +116,7 @@ public void injectIntoClassLoader(LaunchClassLoader launchClassLoader) { | |||
throw new RuntimeException("Could not locate Minecraft: provider locate failed"); | |||
} | |||
|
|||
arguments = null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why null out the arguments? Just because they're not needed anymore?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe to allow garbage collection?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just to trap any accidental reuse
Thank you for this |
Little note for people coming from FabricMC/fabric-installer#53, #181, #357, #521, #512, FabricMC/fabric#1123, #671, #615:
|
This allows to specify extra mods with
Each takes a path separated list similar to the class path, e.g.
--fabric.addMods=path/modA.jar:/some/path/modB.jar
on Linux/MacOS or--fabric.addMods=path/modA.jar;/some/path/modB.jar
on WindowsValid entries for this list are:
A mod list reference like
-Dfabric.addMods=@/some/modList.txt
expects modList.txt to contain e.g.This PR touches argument handling to ensure correct behavior with Launchwrapper and move some MC specific code where it belongs.
resolves #282 - the launcher has to translate to plain paths though