Update test file for #650 #5495
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -33,7 +31,6 @@ void failOnUnknownPropertyUnwrapped() throws Exception { | |||
| final String JSON = "{'field': 'value', 'bad':'bad value'}"; | |||
| try { | |||
| mapper.readValue(a2q(JSON), A.class); | |||
| fail("Exception was not thrown on unknown property"); | |||
Member
There was a problem hiding this comment.
What?! No. This is the whole thing to check -- why issue #650 is still valid.
Member
|
@JacksonJang I don't think #650 has been resolved: the expected exception is not being thrown. |
Contributor
Author
|
@cowtowncoder thank you for pointing it out. |
Member
|
Also: yes, CI was failing for all users due to CI / code-coverage change, but now fixed I hope. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue has already been resolved through #5466,
so I moved this test out of
tofixpackage.