Skip to content

Update test file for #650 #5495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
JacksonJang wants to merge 3 commits into from
+1 −4
Closed

Update test file for #650 #5495

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
fe70f27
Update test file for #650
JacksonJang Dec 10, 2025
271d244
Remove fail
JacksonJang Dec 10, 2025
1f39a6c
Merge branch '3.x' into fix-650
cowtowncoder Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 1 addition & 4 deletions ...nd/tofix/UnwrappedWithUnknown650Test.java → ...nd/deser/UnwrappedWithUnknown650Test.java
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package tools.jackson.databind.tofix;
package tools.jackson.databind.deser;

import org.junit.jupiter.api.Test;

Expand All @@ -8,7 +8,6 @@
import tools.jackson.databind.exc.UnrecognizedPropertyException;
import tools.jackson.databind.json.JsonMapper;
import tools.jackson.databind.testutil.DatabindTestUtil;
import tools.jackson.databind.testutil.failure.JacksonTestFailureExpected;

import static org.junit.jupiter.api.Assertions.fail;

Expand All @@ -23,7 +22,6 @@ static class B {
}


@JacksonTestFailureExpected
@Test
void failOnUnknownPropertyUnwrapped() throws Exception {
final ObjectMapper mapper = JsonMapper.builder()
Expand All @@ -33,7 +31,6 @@ void failOnUnknownPropertyUnwrapped() throws Exception {
final String JSON = "{'field': 'value', 'bad':'bad value'}";
try {
mapper.readValue(a2q(JSON), A.class);
fail("Exception was not thrown on unknown property");
Copy link
Member

@cowtowncoder cowtowncoder Dec 10, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What?! No. This is the whole thing to check -- why issue #650 is still valid.

} catch (UnrecognizedPropertyException e) {
verifyException(e, "Unrecognized property");
}
Expand Down
Loading